expression: implement vectorized evaluation for builtinTanSig (#12238)

pingcap · Sep 18, 2019 · 6c0ec62 · 6c0ec62
1 parent 29a1961
commit 6c0ec62
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/expression/builtin_math_vec.go b/expression/builtin_math_vec.go
@@ -177,6 +177,24 @@ func (b *builtinCosSig) vectorized() bool {
 	return true
 }
 
+func (b *builtinTanSig) vecEvalReal(input *chunk.Chunk, result *chunk.Column) error {
+	if err := b.args[0].VecEvalReal(b.ctx, input, result); err != nil {
+		return err
+	}
+	f64s := result.Float64s()
+	for i := 0; i < len(f64s); i++ {
+		if result.IsNull(i) {
+			continue
+		}
+		f64s[i] = math.Tan(f64s[i])
+	}
+	return nil
+}
+
+func (b *builtinTanSig) vectorized() bool {
+	return true
+}
+
 func (b *builtinAbsDecSig) vecEvalDecimal(input *chunk.Chunk, result *chunk.Column) error {
 	if err := b.args[0].VecEvalDecimal(b.ctx, input, result); err != nil {
 		return err

diff --git a/expression/builtin_math_vec_test.go b/expression/builtin_math_vec_test.go
@@ -43,6 +43,9 @@ var vecBuiltinMathCases = map[string][]vecExprBenchCase{
 	ast.Cos: {
 		{types.ETReal, []types.EvalType{types.ETReal}, nil},
 	},
+	ast.Tan: {
+		{types.ETReal, []types.EvalType{types.ETReal}, nil},
+	},
 	ast.Abs: {
 		{types.ETDecimal, []types.EvalType{types.ETDecimal}, nil},
 	},