*: add a blacklist to disallow pushing down specific expressions (#10688) #10998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
added
sig/execution
tidb [127.0.0.1]> select * from mysql.expr_pushdown_blacklist;
ERROR 1146 (42S02): Table 'mysql.expr_pushdown_blacklist' doesn't exist
tidb [127.0.0.1]> select * from tidb where variable_name='tidb_server_version';
+---------------------+----------------+-----------------------------------+
| VARIABLE_NAME | VARIABLE_VALUE | COMMENT |
+---------------------+----------------+-----------------------------------+
| tidb_server_version | 24 | Bootstrap version. Do not delete. |
+---------------------+----------------+-----------------------------------+
1 row in set (0.01 sec)
tidb [127.0.0.1]> select tidb_Version();
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tidb_Version() |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Release Version: v2.1.13-1-gc30c923
Git Commit Hash: c30c923ddfdf832b09fae301ad42e7590fa3d5e9
Git Branch: release-2.1
UTC Build Time: 2019-07-02 06:46:03
GoVersion: go version go1.12 linux/amd64
Race Enabled: false
TiKV Min Version: 2.1.0-alpha.1-ff3dd160846b7d1aed9079c389fc188f7f5ea13e
Check Table Before Drop: false |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)after upgrade: tidb> select * from mysql.tidb where variable_name="tidb_server_version";
+---------------------+----------------+-----------------------------------+
| VARIABLE_NAME | VARIABLE_VALUE | COMMENT |
+---------------------+----------------+-----------------------------------+
| tidb_server_version | 25 | Bootstrap version. Do not delete. |
+---------------------+----------------+-----------------------------------+
tidb> show tables;
+-------------------------+
| Tables_in_mysql |
+-------------------------+
| GLOBAL_VARIABLES |
| columns_priv |
| db |
| expr_pushdown_blacklist |
| gc_delete_range |
| gc_delete_range_done |
| help_topic |
| stats_buckets |
| stats_feedback |
| stats_histograms |
| stats_meta |
| tables_priv |
| tidb |
| user |
+-------------------------+
14 rows in set (0.01 sec)
tidb> select * from mysql.tidb where variable_name="tidb_server_version";
+---------------------+----------------+-----------------------------------+
| VARIABLE_NAME | VARIABLE_VALUE | COMMENT |
+---------------------+----------------+-----------------------------------+
| tidb_server_version | 25 | Bootstrap version. Do not delete. |
+---------------------+----------------+-----------------------------------+
tidb> show tables;
+-------------------------+
| Tables_in_mysql |
+-------------------------+
| GLOBAL_VARIABLES |
| columns_priv |
| db |
| expr_pushdown_blacklist |
| gc_delete_range |
| gc_delete_range_done |
| help_topic |
| stats_buckets |
| stats_feedback |
| stats_histograms |
| stats_meta |
| tables_priv |
| tidb |
| user |
+-------------------------+
14 rows in set (0.00 sec) |
…erry-pick-expr-blacklist
XuHuaiyu
force-pushed
the
cherry-pick-expr-blacklist
branch
from
37441ba to
383544b
Compare
|
/run-all-tests |
|
/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
zz-jason
added
the
priority/release-blocker
|
/run-integration-ddl-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
…iyu/tidb into cherry-pick-expr-blacklist
…erry-pick-expr-blacklist
|
/run-integration-ddl-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #10688
Should merge pingcap/parser#368 first