-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add a blacklist to disallow pushing down specific expressions #10688
Conversation
f271a2a
to
a2e0c8b
Compare
Codecov Report
@@ Coverage Diff @@
## master #10688 +/- ##
================================================
- Coverage 80.3172% 80.1728% -0.1444%
================================================
Files 415 416 +1
Lines 88260 88389 +129
================================================
- Hits 70888 70864 -24
- Misses 12181 12285 +104
- Partials 5191 5240 +49 |
a2e0c8b
to
34192fa
Compare
related PR: pingcap/parser#350 |
session/session.go
Outdated
@@ -1412,6 +1413,21 @@ func loadSystemTZ(se *session) (string, error) { | |||
return req.GetRow(0).GetString(0), nil | |||
} | |||
|
|||
func loadExprPushdownBlacklist(se *session) (err error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we merge this function with Next()
? Seems that they are the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
What problem does this PR solve?
This commit adds a switch to support manually control wether to push down expressions.
What is changed and how it works?
mysql.expr_pushdown_blacklist
Check List
Tests
As the above mentioned.
Code changes
Side effects
N/A
Related changes