please support savepoint

[aesirteam]

Please answer these questions before submitting your issue. Thanks!

1. What did you do?
   If possible, provide a recipe for reproducing the error.

START TRANSACTION;
SELECT 1 FROM dual;
SAVEPOINT save1;
SELECT 1 FROM dual;
ROLLBACK TO SAVEPOINT save1;
COMMIT;

2. What did you expect to see?

All statements succeed.

3. What did you see instead?

mysql> START TRANSACTION;
Query OK, 0 rows affected (0.00 sec)

mysql> SELECT 1 FROM dual;
+---+
| 1 |
+---+
| 1 |
+---+
1 row in set (0.00 sec)

mysql> SAVEPOINT save1;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 9 near "SAVEPOINT save1" 
mysql> SELECT 1 FROM dual;
+---+
| 1 |
+---+
| 1 |
+---+
1 row in set (0.00 sec)

mysql> ROLLBACK TO SAVEPOINT save1;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 11 near "TO SAVEPOINT save1" 
mysql> COMMIT;
Query OK, 0 rows affected (0.00 sec)

4. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?
   Release Version: v2.1.0-alpha-48-ge2c8c4e
   Git Commit Hash: e2c8c4e
   Git Branch: master
   UTC Build Time: 2018-06-13 12:05:19
   GoVersion: go version go1.10.2 linux/amd64
   Race Enabled: false
   TiKV Min Version: 2.1.0-alpha.1-c4133d3ef0f099f8716a916c198390b26293ec00

[zimulala]

@aesirteam
We don't support savepoint, and it isn't on our roadmap now.

[breezewish]

Duplicate with #3663

[muyu66]

Why don't support? I think it's important to implement Sequelize's Callback transaction

[lysu]

@muyu66 yes, savepoint is a very useful feature, it's not on our short-term roadmap, but we maybe try to implement that in future, and welcome to contribute too~

[ihipop]

@lysu pingcap/docs#682 this pull just add the compatibility of savepoint,not the function implementation of savepoint,is it right?

[lysu]

@ihipop , yes , savepoint isn't supported until now..

[chris-ng-scmp]

Good to see if savepoint can be supported

[wuwangben]

Is there a plan to support savepoint?

[wzru]

Recently when I test GORM and TiDB compatibility (inspired by #24194)
GORM tests failed because TiDB has not supported SAVEPOINT:

2021/08/16 11:14:38 gorm.io/driver/mysql@v1.1.1/mysql.go:330 
Error 1064: You have an error in your SQL syntax; 
check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 11 near "TO SAVEPOINT save_point1"
[0.190ms] [rows:0] ROLLBACK TO SAVEPOINT save_point1
--- FAIL: TestTransactionWithSavePoint (0.01s)
    transaction_test.go:193: Should not find rollbacked record

With SAVEPOINT supported, TiDB will also be more compatible with GORM.

[bb7133]

@wzru Yes, savepoint is on the roadmap, thanks!

[Allan-Nava]

Any news?

[xujiajun]

+1

[cjphaha]

Is it supported now?

[crazycs520]

I will work on this now

[cjphaha]

I will work on this now

Hi bro, is it convenient to ask? Which version supports savepoint？

[crazycs520]

I will work on this now

Hi bro, is it convenient to ask? Which version supports savepoint？

If it goes well, savepoint may be supported in TiDB v6.2.0.

[mstao]

+1, Seata needs the support of saveponit. ROLLBACK TO SAVEPOINT

[fishfree]

@crazycs520 I notice v6.2.0 just released, is the feature SAVEPOINT added in it?

[xhebox]

@crazycs520 I notice v6.2.0 just released, is the feature SAVEPOINT added in it?

Yes. You could check release notes here. It seems that github release notes are not completed.

[HashJang]

Since savepoint is implemented, why is it still stated that in the document:

@transactional(propagation = Propagation.NESTED) is not supported

[Icemap]

Since savepoint is implemented, why is it still stated that in the document:
@transactional(propagation = Propagation.NESTED) is not supported

@HashZhang Nice catch! I'll update develop guide ASAP.

[Icemap]

Actually, I already updated the Choose Driver or ORM doc.
So, as we talked before. Maybe cheery-pick this PR to all versions is a good idea? @Oreoxmt PTAL

[Oreoxmt]

Actually, I already updated the Choose Driver or ORM doc. So, as we talked before. Maybe cheery-pick this PR to all versions is a good idea? @Oreoxmt PTAL

This note has been added to v6.1 and later versions. https://docs.pingcap.com/tidb/stable/dev-guide-choose-driver-or-orm