self.use_transactional_tests = false for all test cases
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Active Record test case depends on database savepoint feature to restore the database status by default as `self.use_transactional_tests = true` As of TiDB 5.2, it does not support savepoint feature yet then changing `self.use_transactional_tests = false` for all test cases until it is implemented. Refer pingcap/tidb#6840
|
Follow up #22 (comment) |
|
Opened as a draft pull request since I am not sure this code is enough yet. |
|
Once this pull request is green and merged, this line can be reverted https://github.com/pingcap/rails/blob/1f68df160a11fd7ed7e52eed898cb47bff3b3751/activerecord/test/cases/test_case.rb#L23 |
|
Since TiDB 6.2 supports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Active Record test case depends on database savepoint feature to restore the database status by default as
self.use_transactional_tests = trueAs of TiDB 5.2, it does not support savepoint feature yet then
changing
self.use_transactional_tests = falsefor all test cases until it isimplemented.
Refer
pingcap/tidb#6840