Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Clear redundant log methods #444

Merged
merged 3 commits into from
Jun 12, 2021
Merged

*: Clear redundant log methods #444

merged 3 commits into from
Jun 12, 2021

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Jun 12, 2021

What problem does this PR solve?

Based on pingcap/tidb#25381

close #445

Clear redundant log methods.

What is changed and how it works?

  • Remove redundant InitLogger with is the same as logutil. InitLogger in tidb.
  • Replace InitZapLogger with InitLogger

@tisonkun tisonkun changed the title Update executable_checker.go *: Clear redundant log methods Jun 12, 2021
@Ehco1996
Copy link
Contributor

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: edabd0d

@ti-chi-bot ti-chi-bot merged commit 09e10c7 into master Jun 12, 2021
@tisonkun
Copy link
Contributor Author

@amyangfei could you please take a look at pingcap/tidb#25381 ? From the description this PR is based on that PR. Because TiDB has a snippet of code using pumpcli. InitLogger, which can be removed though.

@lichunzhu lichunzhu deleted the tisonkun-patch-1 branch November 22, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant log methods
4 participants