Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate InitZapLogger and prefer InitLogger #25380

Closed
Tracked by #24190
tisonkun opened this issue Jun 12, 2021 · 0 comments · Fixed by #25381
Closed
Tracked by #24190

deprecate InitZapLogger and prefer InitLogger #25380

tisonkun opened this issue Jun 12, 2021 · 0 comments · Fixed by #25381
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Jun 12, 2021 •
edited
Loading

Development Task

subtask of #24190

InitLogger is a more abstract name than InitZapLogger. We should program with abstraction, not implementation.

InitZapLogger is still used in tidb-tools which will be later removed with pingcap/tidb-tools#444. And then we can safely remove InitZapLogger. We might pay more attention when publishing methods.
@tisonkun tisonkun added the type/enhancement The issue or PR belongs to an enhancement. label Jun 12, 2021
This was referenced Jun 12, 2021
Merged
Closed
@tisonkun tisonkun changed the title deprecated InitZapLogger and prefer InitLogger remove InitZapLogger and prefer InitLogger Jun 14, 2021
@tisonkun tisonkun changed the title remove InitZapLogger and prefer InitLogger deprecate InitZapLogger and prefer InitLogger Jun 14, 2021
@tisonkun tisonkun mentioned this issue Jul 16, 2021
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

logutil: InitLogger as a more abstract method, deprecated InitZapLogger tisonkun/tidb
1 participant
@tisonkun