Fix the pump/drainer data dir to avoid data loss caused by bad configuration #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration Signed-off-by: Aylei <rayingecho@gmail.com>
|
@tennix @weekface @onlymellb PTAL |
|
/run-e2e-tests |
weekface
approved these changes
Aug 27, 2019
|
/run-e2e-tests |
onlymellb
approved these changes
Aug 27, 2019
|
/run-e2e-in-kind |
2 similar comments
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
cherry pick to release-1.0 failed |
aylei
added a commit
to aylei/tidb-operator
that referenced
this pull request
Nov 19, 2019
…upstream-release-1.0
aylei
added a commit
to aylei/tidb-operator
that referenced
this pull request
Nov 19, 2019
…upstream-release-1.0
aylei
added a commit
to aylei/tidb-operator
that referenced
this pull request
Nov 19, 2019
…upstream-release-1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aylei rayingecho@gmail.com
What problem does this PR solve?
We allow users to specify a customized configuration file for
pumpanddrainer, but if the user forget to configure thedata-dirin config file or configure it wrongly, there are potential data loss risk.This PR fix this problem.
What is changed and how does it work?
Fix the
data-dirvia command line arguments.Check List
Tests
Code changes
Related changes
Does this PR introduce a user-facing change?: