Skip to content

Commit

Permalink
Fix the pump/drainer data dir to avoid data loss caused by bad config…
Browse files Browse the repository at this point in the history
…uration (#826)

Signed-off-by: Aylei <rayingecho@gmail.com>
  • Loading branch information
aylei authored Aug 27, 2019
1 parent c62324d commit b48e7c9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,5 @@ done
-config=/etc/drainer/drainer.toml \
-disable-detect={{ .Values.binlog.drainer.disableDetect | default false }} \
-initial-commit-ts={{ .Values.binlog.drainer.initialCommitTs | default 0 }} \
-data-dir=/data \
-log-file=
1 change: 1 addition & 0 deletions charts/tidb-cluster/templates/scripts/_start_pump.sh.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -euo pipefail
-L={{ .Values.binlog.pump.logLevel | default "info" }} \
-advertise-addr=`echo ${HOSTNAME}`.{{ template "cluster.name" . }}-pump:8250 \
-config=/etc/pump/pump.toml \
-data-dir=/data \
-log-file=

if [ $? == 0 ]; then
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,5 @@ done
-config=/etc/drainer/drainer.toml \
-disable-detect={{ .Values.disableDetect | default false }} \
-initial-commit-ts={{ .Values.initialCommitTs | default 0 }} \
-data-dir=/data \
-log-file=""

0 comments on commit b48e7c9

Please sign in to comment.