GKE local ssd provisioner for COS #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On COS, remount with UUID and set nobarrier. We do not combine multiple like on Ubuntu. Therefore this is recommended if your data size is < 375 GiB
cofyc
reviewed
Jul 1, 2019
| We also have a [daemonset](../manifests/gke/local-ssd-provision.yaml) that | ||
| * fixes any performance issues | ||
| * remounts local SSD disks with a UUID for safety | ||
| * On Ubuntu combines all local SSD disks into one large disk with lvm tools. |
There was a problem hiding this comment.
Should we let the user decide whether to combine the disks? In case users need to deploy multiple TiKV instances on one node.
There was a problem hiding this comment.
In the cloud I don't think it makes sense to deploy multiple TiKV instances to one node. I am more concerned about a cluster that both runs tidb-operator and something else. But it is up to them to take these daemonsets and use them appropriately.
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The Ubuntu local SSD provisioner has a startup delay while provisioning packages. Make the local SSD provisioner work on COS.
What is changed and how does it work?
On COS, remount with UUID and set nobarrier.
We do not combine multiple disk like on Ubuntu.
Therefore this is recommended if your data size is < 375 GiB.
Note that by default COS does not set the nobarrier option. This script sets the nobarrier option when it remounts.
Check List
Tests
Code changes
Side effects
kubectl delete -n kube-system local-volume-provisioner.Does this PR introduce a user-facing change?: