-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.0, dev/how-to/maintain: fix wording in kubernetes doc #1607
v3.0, dev/how-to/maintain: fix wording in kubernetes doc #1607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* 确保 SSD 挂载选项中包含 `nobarrier`。 | ||
|
||
我们提供一个解决上述问题的 [Daemonset](https://raw.githubusercontent.com/pingcap/tidb-operator/master/manifests/gke/local-ssd-optimize.yaml)。还提供一个解决上述性能问题并且将多块 SSD 盘配置成一个 LVM 的 | ||
[Daemonset](https://raw.githubusercontent.com/pingcap/tidb-operator/master/manifests/gke/local-ssd-provision/local-ssd-provision.yaml)。通过 Terraform 部署的时候会自动安装。 | ||
[Daemonset](https://raw.githubusercontent.com/pingcap/tidb-operator/master/manifests/gke/local-ssd-optimize.yaml) 提供了一个解决上述性能问题的方案,并且将多块 SSD 盘配置成一个 LVM。通过 Terraform 部署的时候会进行自动安装。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid this is not the original meaning. Please check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to pingcap/tidb-operator#612 for latest update.
I have ported that change to docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already updated this part according to the English version. See the commit below.
Important Update: We have added a markdownlint static check in the CI check to improve the quality of our documentation, so your unclosed PR might fail the CI check now. First, you should merge master to your branch, so the upstream changes might resolve the issues found by the CI check. Then, click @TomShawn If you have any problem with troubleshooting, please consult @yikeke for help. Thanks for your cooperation~ Ref: #1494 |
@yikeke Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is changed, added or deleted?
This PR changes the abbreviation
COS
to its full name, Container-Optimized OS.Related doc
https://github.com/pingcap/tidb-operator/blob/master/docs/operation-guide.md
Which version does your change affect?
v3.0, dev
Checklist
title
in metadataTOC.md