Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix operator chart issue #419

Merged
merged 1 commit into from
Apr 28, 2019
Merged

fix operator chart issue #419

merged 1 commit into from
Apr 28, 2019

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Apr 23, 2019 •
edited
Loading

this pr fixes: #379

@weekface
Copy link
Contributor Author

/run-e2e-tests

zyguan
zyguan approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@zyguan zyguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaojingchen
xiaojingchen approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@xiaojingchen xiaojingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LinuxGit
LinuxGit approved these changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@LinuxGit LinuxGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 9cbb992 into pingcap:master Apr 28, 2019
@weekface weekface deleted the fix-chart branch April 28, 2019 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxGit LinuxGit LinuxGit approved these changes

@xiaojingchen xiaojingchen xiaojingchen approved these changes

@zyguan zyguan zyguan approved these changes

@tennix tennix Awaiting requested review from tennix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some problems in charts
4 participants
@weekface @LinuxGit @xiaojingchen @zyguan