Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some problems in charts #379

Closed
zyguan opened this issue Apr 9, 2019 · 0 comments · Fixed by #419
Closed

Some problems in charts #379

zyguan opened this issue Apr 9, 2019 · 0 comments · Fixed by #419
Labels
test/stability stability tests type/bug Something isn't working

Comments

@zyguan
Copy link
Contributor

zyguan commented Apr 9, 2019 •
edited
Loading

Missing imagePullPolicy: {{ .Values.imagePullPolicy | default "IfNotPresent" }}

tidb-operator/charts/tidb-operator/templates/scheduler-deployment.yaml

Lines 30 to 31 in dec665f

image: {{ .Values.operatorImage }}
resources:

Missing -tikv-failover-period={{ .Values.controllerManager.tikvFailoverPeriod | default "5m" }}

tidb-operator/charts/tidb-operator/templates/controller-manager-deployment.yaml

Lines 39 to 40 in b4f6d68

- -pd-failover-period={{ .Values.controllerManager.pdFailoverPeriod | default "5m" }}
- -tidb-failover-period={{ .Values.controllerManager.tidbFailoverPeriod | default "5m" }}

@zyguan zyguan added the type/bug Something isn't working label Apr 9, 2019
@zyguan zyguan changed the title Missing imagePullPolicy in scheduler-deployment.yaml Some problems in charts Apr 10, 2019
@weekface weekface added the test/stability stability tests label Apr 10, 2019
@weekface weekface mentioned this issue Apr 23, 2019
Merged
yahonda pushed a commit that referenced this issue Dec 27, 2021
@cofyc
Update tidb-operator version to v1.1.0 in kind tutorial (#379)
314a436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test/stability stability tests type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix operator chart issue weekface/tidb-operator
2 participants
@weekface @zyguan