Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalPrintColumns for TidbCluster CRD #361

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Apr 1, 2019

Testing result in my local 1.13 cluster:

kubectl get tidbcluster
NAME           PD                  STORAGE   READY   DESIRE   TIKV                  STORAGE   READY   DESIRE   TIDB                  READY   DESIRE
aylei-master   pingcap/pd:v2.1.0   1Gi       3       3        pingcap/tikv:v2.1.0   10Gi      5       5        pingcap/tidb:v2.1.0   4       4

Signed-off-by: Aylei rayingecho@gmail.com

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Copy link
Contributor Author

aylei commented Apr 1, 2019

close #361

@aylei aylei requested a review from gregwebs April 1, 2019 03:48
@aylei
Copy link
Contributor Author

aylei commented Apr 1, 2019

/run-e2e-tests

type: integer
description: The ready replicas number of PD cluster
JSONPath: .status.pd.statefulSet.readyReplicas
- name: Desire
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally this would be "Desired".

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@aylei aylei merged commit f3bfb48 into pingcap:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants