Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additionalPrinterColumns in TidbCluster CRD #358

Closed
aylei opened this issue Mar 31, 2019 · 2 comments
Closed

Add additionalPrinterColumns in TidbCluster CRD #358

aylei opened this issue Mar 31, 2019 · 2 comments
Assignees

Comments

@aylei
Copy link
Contributor

aylei commented Mar 31, 2019

Starting with Kubernetes 1.11, CRD spec supports additionalPrinterColumns definition, which can facilitate CRD viewing from kubectl.

This enhancement is not conflict with the CLI tool, while both boosting the user experience in command line.

@aylei
Copy link
Contributor Author

aylei commented Mar 31, 2019

A simple example

  additionalPrinterColumns:
  - name: PD Ready
    type: integer
    description: The ready replicas number of PD cluster
    JSONPaht: .status.pd.statefulSet.readyReplicas
  - name: PD Desired
    type: integer
    description: The desired replicas number of PD cluster
    JSONPath: .spec.pd.replicas

I will open a PR to discuss which columns do we need.

@aylei aylei self-assigned this Mar 31, 2019
@aylei
Copy link
Contributor Author

aylei commented Apr 1, 2019

close via #361

@aylei aylei closed this as completed Apr 1, 2019
yahonda pushed a commit that referenced this issue Dec 27, 2021
* refine troubleshooting

* Update zh/deploy-failures.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* Update zh/exceptions.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* Update zh/exceptions.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* Update zh/network-issues.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* address comment

* address comment

* address comment

* Update zh/deploy-failures.md

Co-authored-by: Ran <huangran@pingcap.com>

* Update zh/deploy-failures.md

Co-authored-by: Ran <huangran@pingcap.com>

* Update zh/deploy-failures.md

Co-authored-by: Ran <huangran@pingcap.com>

* Update zh/deploy-failures.md

Co-authored-by: Ran <huangran@pingcap.com>

* address comment

* fix ci

* address comment

* address comment

* address comment

* address comment

* Update zh/deploy-failures.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* Update zh/deploy-failures.md

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

* Update zh/exceptions.md

Co-authored-by: Ran <huangran@pingcap.com>

* Apply suggestions from code review

Co-authored-by: Ran <huangran@pingcap.com>

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant