-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatically set the scheduler K8s version #313
Conversation
This is tested to work on GKE
This looks great! Previously we use hyperkube image built by coreos hosted on quay.io. And the image is I'm not sure if this can still work for other registry images and I guess it's quite fragile. But if it works for |
Users on other platforms besides GKE will still pull this pulbic image from the gcr.io without issue (unless they are behind the GFW). But yes, their GitVersion may not match. We should be able to make a more complicated function that can accomodate different environments. For example that can also remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-e2e-tests |
1 similar comment
/run-e2e-tests |
/run-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is tested to work on GKE. If this approach is approved, we will need to update some docs.
There is some relation to #278: after this change one should perform a helm upgrade when the K8s version changes (normally this would only matter for a major version change).
It is also possible to try to construct the string from Capabilities.KubeVersion.Major + Capabilities.KubeVersion.Minor.
However, that give me
1.12+
rather than1.12.5
. So the GitVersion approach seems to match our user guide.