-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax hyperkube version match requirement? #278
Comments
I think it should be possible for us to default to matching what K8s is running (and even track if it changes) |
@kkimdev The pods created by TiDB Operator are scheduled by TiDB Scheduler(kube-scheduler + tidb-scheduler). We recommend keeping consistent, but these two versions can be different actually. |
Major version changes of k8s will definitely break this setup. Otherwise we would need some code to monitor the K8s version and change the image tag when the K8s version changes. |
We now default the helm chart to try to match the k8s version, and it works on GKE. @kkimdev can you try it out on your K8s install? |
It worked well on both gke and kubeadm-dind-cluster. Thanks! |
Currently users are supposed to match hyperkube's version to Kubernetes' version by
--set scheduler.kubeSchedulerImage=gcr.io/google-containers/hyperkube:${KUBE_VERSION}
However, some managed Kubernetes service provides automatic Kubernetes version upgrade which can introduce version mismatch overnight. It would be great if this exact version match requirement can be relaxed.
I don't know the technical feasibility about this though.
The text was updated successfully, but these errors were encountered: