Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add block-cache-size to values.yaml #252

Merged
merged 9 commits into from
Dec 27, 2018
Merged

add block-cache-size to values.yaml #252

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f141074
add block-cache-size to values.yaml
weekface Dec 25, 2018
b331c70
Merge branch 'master' into add-block-cache
weekface Dec 25, 2018
4628b25
Merge branch 'master' into add-block-cache
weekface Dec 26, 2018
1e34a20
address comment
weekface Dec 26, 2018
cc77d60
Merge branch 'add-block-cache' of https://github.com/weekface/tidb-op…
weekface Dec 26, 2018
a3baabc
address comment
weekface Dec 26, 2018
3471ca3
Merge branch 'master' into add-block-cache
weekface Dec 26, 2018
46d82b0
Merge branch 'master' into add-block-cache
tennix Dec 27, 2018
4b0f34b
Merge branch 'master' into add-block-cache
tennix Dec 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions charts/tidb-cluster/templates/config/_tikv-config.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,11 @@ sync-log = {{ .Values.tikv.syncLog }}

# block-cache used to cache uncompressed blocks, big block-cache can speed up read.
# in normal cases should tune to 30%-50% system's total memory.
{{- if .Values.tikv.defaultcfBlockCacheSize }}
block-cache-size = {{ .Values.tikv.defaultcfBlockCacheSize | quote }}
{{- else }}
# block-cache-size = "1GB"
{{- end }}

# Indicating if we'd put index/filter blocks to the block cache.
# If not specified, each "table reader" object will pre-load index/filter block
Expand Down Expand Up @@ -437,7 +441,11 @@ sync-log = {{ .Values.tikv.syncLog }}
# target-file-size-base = "8MB"

# in normal cases should tune to 10%-30% system's total memory.
{{- if .Values.tikv.writecfBlockCacheSize }}
block-cache-size = {{ .Values.tikv.writecfBlockCacheSize | quote }}
{{- else }}
# block-cache-size = "256MB"
{{- end }}
# level0-file-num-compaction-trigger = 4
# level0-slowdown-writes-trigger = 20
# level0-stop-writes-trigger = 36
Expand Down
6 changes: 6 additions & 0 deletions charts/tidb-cluster/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ tikv:
# value: tidb
# effect: "NoSchedule"

# block-cache used to cache uncompressed blocks, big block-cache can speed up read.
# in normal cases should tune to 30%-50% tikv.resources.limits.memory
# defaultcfBlockCacheSize: "1GB"
# in normal cases should tune to 10%-30% tikv.resources.limits.memory
# writecfBlockCacheSize: "256MB"

tikvPromGateway:
image: prom/pushgateway:v0.3.1
imagePullPolicy: IfNotPresent
Expand Down