Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add block-cache-size to values.yaml #252

Merged
merged 9 commits into from
Dec 27, 2018
Merged

Conversation

weekface
Copy link
Contributor

This pr adds the two block-cache-size options to values.yaml

@tennix @onlymellb @xiaojingchen PTAL

@weekface
Copy link
Contributor Author

/run-e2e-tests

xiaojingchen
xiaojingchen previously approved these changes Dec 26, 2018
Copy link
Contributor

@xiaojingchen xiaojingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix
Copy link
Member

tennix commented Dec 26, 2018

There are some parameters related to CPU numbers need to be exposed in values.yaml

[readpool.storage]
high-concurrency = 4
normal-concurrency = 4
low-concurrency = 4
[readpool.coprocessor]
high-concurrency = 8
normal-concurrency = 8
low-concurrency = 8
[storage]
scheduler-worker-pool-size = 4

The three concurrency can be set to the same value.

@weekface
Copy link
Contributor Author

/run-e2e-tests

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit 4b469da into pingcap:master Dec 27, 2018
@weekface weekface deleted the add-block-cache branch June 21, 2019 08:38
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants