Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate tidb.initializer.resources to initcontainer in tidb initiali… (#1938) #2005

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 23, 2020

cherry-pick #1938 to release-1.1


…zer job

What problem does this PR solve?

fixes #1911

What is changed and how does it work?

Being able to allocate resources for InitContainers in TiDB Initializer Job by using options defined in values.yaml.

Check List

Tests

  • No code

Does this PR introduce a user-facing change?:

Allow users to define resources for initContainers in TiDB initializer job.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 23, 2020

Your auto merge job has been accepted, waiting for 2009

@DanielZhangQD
Copy link
Contributor

/run-all-tests

1 similar comment
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 23, 2020

/run-all-tests

@sre-bot sre-bot merged commit 989beee into pingcap:release-1.1 Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants