Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resources configuration for InitContainer in TiDB initializer job #1911

Closed
tfulcrand opened this issue Mar 11, 2020 · 7 comments · Fixed by #1938
Closed

Allow resources configuration for InitContainer in TiDB initializer job #1911

tfulcrand opened this issue Mar 11, 2020 · 7 comments · Fixed by #1938
Assignees

Comments

@tfulcrand
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

When we run TiDB cluster with init options for TiDB component in a namespace with defined quotas, we get an error for tidb-cluster-tidb-initializer job object like
Warning FailedCreate 3s job-controller Error creating: pods "tidb-cluster-tidb-initializer-cwx85" is forbidden: failed quota: karazhan-quota: must specify limits.memory,requests.cpu,requests.memory
Investigations show us that the initContainer of this job has no ressources defined.

Describe the feature you'd like:

Allow to use the TiDB initializer job in namespace with quotas.

@DanielZhangQD
Copy link
Contributor

@tfulcrand Just set tidb.initializer.resources in values.yaml, which is introduced in v1.0.3.

@DanielZhangQD DanielZhangQD self-assigned this Mar 13, 2020
@DanielZhangQD
Copy link
Contributor

@tfulcrand Did you try the above setting?

@tfulcrand
Copy link
Contributor Author

@DanielZhangQD Yes we set tidb.initializer.resources in values.yaml but it dosen't fix the problem.
If you take a look of tidb-initializer-job.yaml, you can see that initContainers named wait has no resources line defined while containers named mysql-client has one.
We believe that this difference explains the problem. We haven't had the time to test adding this missing line yet but as soon as this is done we will offer you a fix.

@DanielZhangQD
Copy link
Contributor

@tfulcrand Yes, you're right. Looking forward to your contribution, Thanks!

@tfulcrand
Copy link
Contributor Author

@DanielZhangQD Is there something wrong with the PR ?

@cofyc
Copy link
Contributor

cofyc commented Mar 20, 2020

@tfulcrand
hi, nothing wrong with the PR, but we may miss the PR. ping us if we don't respond in time.

by the way, you can join our stack channel #sig-tidb-operator via this link.

@DanielZhangQD
Copy link
Contributor

@tfulcrand PR merged, sorry for the late review, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants