Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pausing rolling-update of TidbCluster #1381

Closed
aylei opened this issue Dec 19, 2019 · 5 comments · Fixed by #2013
Closed

support pausing rolling-update of TidbCluster #1381

aylei opened this issue Dec 19, 2019 · 5 comments · Fixed by #2013

Comments

@aylei
Copy link
Contributor

aylei commented Dec 19, 2019

Feature Request

Scenarios:

  • For critical env, pause could be used to avoid unexpected rolling-update caused by a compatible issue of new operator version or an operation error (user fault).
  • Support user to modify the spec multiple times and only apply once, or only apply at maintenance window.

Reference:

  • Pause support of Deployment
@Yisaer
Copy link
Contributor

Yisaer commented Dec 20, 2019

Currently, we already supported this feature. #1377 moved sts webhook config in templates and exposed webhook switch in values.yaml. When users enabled admissionWebhook and statefulset hook, they can pause tidbcluster by adding annotations for tidbcluster object.
@aylei

@aylei
Copy link
Contributor Author

aylei commented Dec 21, 2019

I suppose you are talking about the annotations (tidb.pingcap.com/tidb-partition", tidb.pingcap.com/tikv-partition) for canary release? In some extent it meets the requirement, but it is not actually pause the all the controlling that would mutate cluster pods

@Yisaer
Copy link
Contributor

Yisaer commented Dec 22, 2019

@aylei It seems that this feature requests a method like annotate tidb.pingcap.com/pause to tidbcluster to pause the upgarding without specific the canary release number.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

@github-actions github-actions bot closed this as completed Mar 9, 2020
@cofyc cofyc reopened this Mar 9, 2020
@cofyc cofyc added this to the v1.1.0 milestone Mar 9, 2020
@cofyc cofyc self-assigned this Mar 10, 2020
@cofyc
Copy link
Contributor

cofyc commented Mar 10, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants