Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record tidb cluster workload state in status field #2011

Closed
cofyc opened this issue Mar 23, 2020 · 0 comments · Fixed by #2414
Closed

record tidb cluster workload state in status field #2011

cofyc opened this issue Mar 23, 2020 · 0 comments · Fixed by #2414
Assignees
Milestone

Comments

@cofyc
Copy link
Contributor

cofyc commented Mar 23, 2020

Feature Request

Is your feature request related to a problem? Please describe:

At first, we can add a new condition to indicate the tidb cluster is ready or not:

    // TidbClusterReady indicates that the tidb cluster is ready or not.
    // This is defined as:
    // - All statefulsets are up to date (currentRevision == updateRevision).
    // - All PD members are healthy.
    // - All TiDB pods are healthy.
    // - All TiKV stores are up.
    // - All TiFlash stores are up.
    TidbClusterReady TidbClusterConditionType = "Ready"

Describe the feature you'd like:

like conditions in builtin kubernetes workload objects

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@cofyc cofyc changed the title record tidb cluster state in controller in status record tidb cluster workload state in status field Mar 23, 2020
@cofyc cofyc added this to the v1.1.0 milestone Apr 1, 2020
@cofyc cofyc self-assigned this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant