Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reparo: fix can't decode bit type data (#1103) #1106

Merged
merged 4 commits into from
Feb 9, 2022
Merged

reparo: fix can't decode bit type data (#1103) #1106

merged 4 commits into from
Feb 9, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1103

What problem does this PR solve?

close #1096

What is changed and how it works?

in #655, drainer will write Uint64 datum for mysql bit type. align reparo's behaviour

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#1103
90f137d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 23, 2021
Merged
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Dec 23, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lichunzhu
Copy link
Contributor

/run-all-tests

@lance6716
Copy link
Contributor

/run-integration-test

@niubell
Copy link

niubell commented Feb 8, 2022

/run-integration-test

@lichunzhu
Copy link
Contributor

/run-all-tests

1 similar comment
@lichunzhu
Copy link
Contributor

/run-all-tests

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 0c3aee3

@ti-chi-bot ti-chi-bot merged commit cd66069 into pingcap:release-5.1 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

Assignees

@lance6716 lance6716

Labels
cherry-pick-approved first-time-contributor size/S status/can-merge status/LGT2 type/cherry-pick-for-release-5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @CLAassistant @lichunzhu @lance6716 @niubell @zhouqiang-cl