Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reparo: fix can't decode bit type data #1103

Merged
merged 2 commits into from
Dec 23, 2021
Merged

reparo: fix can't decode bit type data #1103

merged 2 commits into from
Dec 23, 2021

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

close #1096

What is changed and how it works?

in #655, drainer will write Uint64 datum for mysql bit type. align reparo's behaviour

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@lance6716
Copy link
Contributor Author

/run-all-tests

@lance6716
Copy link
Contributor Author

/cc @lichunzhu

I haven't run the integration test locally, not sure if it will pass 😂

@lance6716
Copy link
Contributor Author

/run-all-tests

lichunzhu
lichunzhu approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716
Copy link
Contributor Author

/cc @kennytm

@lance6716
Copy link
Contributor Author

/cc @glorv

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 263478c

@ti-chi-bot ti-chi-bot merged commit d8288e0 into pingcap:master Dec 23, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Dec 23, 2021
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#1103
ea017f6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Dec 23, 2021
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#1103
90f137d 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Dec 23, 2021
Closed
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1105.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1106.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Dec 23, 2021
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#1103
c635d90 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 23, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1107.

ti-chi-bot pushed a commit to ti-chi-bot/tidb-binlog that referenced this pull request Dec 23, 2021
@lance6716 @ti-chi-bot
This is an automated cherry-pick of pingcap#1103
cb8eec5 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 23, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1108.

@lance6716
Copy link
Contributor Author

/cherry-pick release-5.3

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 23, 2021
Merged
@ti-chi-bot
Copy link
Member

@lance6716: new pull request created: #1109.

In response to this:

/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added a commit that referenced this pull request Feb 9, 2022
@ti-chi-bot
reparo: fix can't decode bit type data (#1103) (#1106)
cd66069
ti-chi-bot added a commit that referenced this pull request Feb 18, 2022
@ti-chi-bot
reparo: fix can't decode bit type data (#1103) (#1109)
795af76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
first-time-contributor needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 size/S status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

file output of drainer use KindUint64 for KindMysqlBit
4 participants
@lance6716 @ti-chi-bot @lichunzhu @glorv