Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: replace black-white-list by table filter #3916

Merged
merged 11 commits into from
Jul 13, 2020
Merged

*: replace black-white-list by table filter #3916

merged 11 commits into from
Jul 13, 2020

Conversation

ran-huang
Copy link
Contributor

What is changed, added or deleted? (Required)

  • Add a doc for the "table filter" feature shared by all new TiDB ecosystem tools
  • Update related contents for BR and TiDB Lightning

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang added translation/from-docs This PR is translated from a PR in pingcap/docs. size/large Changes of a large size. needs-cherry-pick-3.1 requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. labels Jul 7, 2020
@ran-huang ran-huang requested review from kennytm and yikeke July 7, 2020 11:09
kennytm
kennytm reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

br/backup-and-restore-tool.md Outdated Show resolved Hide resolved
br/backup-and-restore-tool.md Outdated Show resolved Hide resolved
table-filter.md Outdated Show resolved Hide resolved
table-filter.md Outdated Show resolved Hide resolved
@ran-huang @kennytm
Apply suggestions from code review
d1aef6d 
Co-authored-by: kennytm <kennytm@gmail.com>
@overvenus
Copy link
Member

Please update filter usage in CDC too. https://docs.pingcap.com/zh/tidb/stable/manage-ticdc#%E5%90%8C%E6%AD%A5%E4%BB%BB%E5%8A%A1%E9%85%8D%E7%BD%AE%E6%96%87%E4%BB%B6%E6%8F%8F%E8%BF%B0

@ran-huang
Copy link
Contributor Author

Please update filter usage in CDC too. https://docs.pingcap.com/zh/tidb/stable/manage-ticdc#%E5%90%8C%E6%AD%A5%E4%BB%BB%E5%8A%A1%E9%85%8D%E7%BD%AE%E6%96%87%E4%BB%B6%E6%8F%8F%E8%BF%B0

@overvenus Thanks! Updated in 92a5fd4

@ran-huang ran-huang mentioned this pull request Jul 9, 2020
Merged
5 tasks
@yikeke yikeke requested review from TomShawn and removed request for yikeke July 9, 2020 07:53
@yikeke
Copy link
Contributor

yikeke commented Jul 9, 2020

Please help review this PR, thanks~ @TomShawn

TomShawn
TomShawn reviewed Jul 9, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ran-huang @TomShawn
Apply suggestions from code review
46462b8 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ran-huang
Copy link
Contributor Author

@TomShawn PTAL again, thanks~

TomShawn
TomShawn approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@TomShawn,Thanks for your review.

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2020
TomShawn
TomShawn reviewed Jul 10, 2020
View reviewed changes
table-filter.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 3925

@ran-huang ran-huang merged commit a4c0315 into pingcap:master Jul 13, 2020
@ran-huang ran-huang deleted the table-filter branch July 13, 2020 02:43
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3916 to release-3.0
2e3398d 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3949

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3916 to release-3.1
708e759 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3950

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Jul 13, 2020
@ran-huang @ti-srebot
cherry pick pingcap#3916 to release-4.0
1074357 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 13, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3951

ran-huang added a commit that referenced this pull request Jul 13, 2020
@ti-srebot @ran-huang
*: replace black-white-list by table filter (#3916) (#3951)
7adf0a1 
* cherry pick #3916 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* change aliases

Co-authored-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang mentioned this pull request Jul 13, 2020
Merged
5 tasks
ran-huang added a commit that referenced this pull request Jul 13, 2020
@ti-srebot @ran-huang
*: replace black-white-list by table filter (#3916) (#3949)
afe67ee 
* cherry pick #3916 to release-3.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* resolve conflict and apply version specific changes

* fix a deadlink

* Delete tidb-lightning-table-filter.md

Co-authored-by: Ran <huangran@pingcap.com>
ran-huang added a commit that referenced this pull request Jul 13, 2020
@ti-srebot @ran-huang
*: replace black-white-list by table filter (#3916) (#3950)
5d25a51 
* cherry pick #3916 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update TOC.md

* resolve conflict and apply version-specific changes

* Delete manage-ticdc.md

* fix a deadlink

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@TomShawn TomShawn TomShawn approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ran-huang @overvenus @yikeke @ti-srebot @kennytm @TomShawn