Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dumpling backup document #3541

Merged
merged 8 commits into from
Jun 8, 2020
Merged

Conversation

lichunzhu
Copy link
Contributor

@lichunzhu lichunzhu commented Jun 6, 2020

What is changed, added or deleted? (Required)

Update Dumpling deployment usage.
The new dumpling binary has not been uploaded. I will remove DNM tag once it's ready. The document can be reviewed now.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

export-or-backup-using-dumpling.md Outdated Show resolved Hide resolved
export-or-backup-using-dumpling.md Outdated Show resolved Hide resolved
export-or-backup-using-dumpling.md Show resolved Hide resolved
@yikeke yikeke self-requested a review June 7, 2020 02:45
@yikeke yikeke added needs-cherry-pick-4.0 translation/doing This PR’s assignee is translating this PR. labels Jun 7, 2020
@yikeke yikeke self-assigned this Jun 7, 2020
export-or-backup-using-dumpling.md Outdated Show resolved Hide resolved
export-or-backup-using-dumpling.md Outdated Show resolved Hide resolved
export-or-backup-using-dumpling.md Outdated Show resolved Hide resolved
export-or-backup-using-dumpling.md Outdated Show resolved Hide resolved
export-or-backup-using-dumpling.md Outdated Show resolved Hide resolved
export-or-backup-using-dumpling.md Outdated Show resolved Hide resolved
@lichunzhu
Copy link
Contributor Author

@yikeke PTAL again. The binary has been updated. This PR can be merged now.

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit 3cbabbe into pingcap:master Jun 8, 2020
sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-4.0 in PR #3555

sre-bot added a commit that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
@lichunzhu lichunzhu deleted the updateDumplingDoc branch June 8, 2020 11:40
@yikeke
Copy link
Contributor

yikeke commented Jun 8, 2020

/run-cherry-picker

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-2.1 in PR #3562

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-3.1 in PR #3563

sre-bot pushed a commit to sre-bot/docs-cn that referenced this pull request Jun 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 8, 2020

cherry pick to release-3.0 in PR #3564

sre-bot added a commit that referenced this pull request Jun 8, 2020
* cherry pick #3541 to release-3.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflict

* Update export-or-backup-using-dumpling.md

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
sre-bot added a commit that referenced this pull request Jun 8, 2020
* cherry pick #3541 to release-3.1

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* Update export-or-backup-using-dumpling.md

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
sre-bot added a commit that referenced this pull request Jun 8, 2020
* cherry pick #3541 to release-2.1

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflict

* update a link

* Update export-or-backup-using-dumpling.md

Co-authored-by: Chunzhu Li <lichunzhu@stu.xjtu.edu.cn>
Co-authored-by: yikeke <yikeke@pingcap.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@yikeke yikeke added the size/medium Changes of a medium size. label Jun 19, 2020
@TomShawn
Copy link
Contributor

@yikeke Please beware the changes made in pingcap/docs#3065 when you translate this PR.

@yikeke
Copy link
Contributor

yikeke commented Jun 30, 2020

@yikeke Please beware the changes made in pingcap/docs#3065 when you translate this PR.

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium Changes of a medium size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants