Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dumpling into tidb tools #3453

Merged
merged 23 commits into from
Jul 31, 2020
Merged

add dumpling into tidb tools #3453

merged 23 commits into from
Jul 31, 2020

Conversation

yikeke
Copy link
Contributor

@yikeke yikeke commented Jul 28, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@yikeke yikeke changed the title align the structure of https://github.com/pingcap/docs-cn/pull/3800/ add dumpling into tidb tools Jul 28, 2020
@yikeke yikeke marked this pull request as ready for review July 29, 2020 07:39
@yikeke yikeke requested review from lilin90 and lichunzhu July 29, 2020 07:39
@yikeke yikeke added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Jul 29, 2020
TOC.md Outdated Show resolved Hide resolved
backup-and-restore-using-dumpling-lightning.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
@yikeke yikeke mentioned this pull request Jul 30, 2020
6 tasks
Co-authored-by: Chunzhu Li <lichunzhu@pingcap.com>
TOC.md Outdated Show resolved Hide resolved
backup-and-restore-using-dumpling-lightning.md Outdated Show resolved Hide resolved
@yikeke
Copy link
Contributor Author

yikeke commented Jul 30, 2020

I've resolved/replied to all your comments. The comments are great, thanks! PTAL again @lichunzhu

dumpling-overview.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@lichunzhu,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@yikeke yikeke added status/LGT1 Indicates that a PR has LGTM 1. and removed status/PTAL This PR is ready for reviewing. labels Jul 30, 2020
@yikeke
Copy link
Contributor Author

yikeke commented Jul 30, 2020

PTAL @lilin90

dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
download-ecosystem-tools.md Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
dumpling-overview.md Outdated Show resolved Hide resolved
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 31, 2020
@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 31, 2020
@yikeke
Copy link
Contributor Author

yikeke commented Jul 31, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 31, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@yikeke yikeke merged commit 0ad1a6a into pingcap:master Jul 31, 2020
@yikeke yikeke deleted the update-dumpling branch July 31, 2020 08:44
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 31, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3498

---
title: Use Dumpling and TiDB Lightning for Data Backup and Restoration
summary: Introduce how to use Dumpling and TiDB Lightning to backup and restore full data of TiDB.
aliases: ['/docs-cn/dev/export-or-backup-using-dumpling/','/zh/tidb/dev/export-or-backup-using-dumpling']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the two aliases in a0ec32a.

yikeke added a commit that referenced this pull request Jul 31, 2020
* cherry pick #3453 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Delete export-or-backup-using-dumpling.md

* update aliases

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Co-authored-by: yikeke <yikeke@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
require-LGT1 Indicates that the PR requires an LGTM. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants