Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[cherry-pick] backup: more detailed TiKV error message(tidb#27567) #1444

Merged
merged 2 commits into from
Nov 24, 2021
Merged

[cherry-pick] backup: more detailed TiKV error message(tidb#27567) #1444

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caba877
backup: more detailed TiKV error message (#27567)
YuJuncen Aug 25, 2021
bc15159
Merge branch 'release-4.0' into release-4.0-cherry-pick-27567
ti-chi-bot Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/backup/push.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,16 @@ func (push *pushDown) pushBackup(
log.Error("", zap.String("error", berrors.ErrKVStorage.Error()+": "+errMsg),
zap.String("work around", "please ensure br and tikv node share a same disk and the user of br and tikv has same uid."))
}

if utils.MessageIsPermissionDeniedStorageError(errPb.GetMsg()) {
errMsg := fmt.Sprintf("I/O permission denied error occurs on TiKV Node(store id: %v; Address: %s)", store.GetId(), redact.String(store.GetAddress()))
log.Error("", zap.String("error", berrors.ErrKVStorage.Error()+": "+errMsg),
zap.String("work around", "please ensure tikv has permission to read from & write to the storage."))
}
return res, berrors.ErrKVStorage
return res, errors.Annotatef(berrors.ErrKVStorage, "error happen in store %v at %s: %s",
store.GetId(),
redact.String(store.GetAddress()),
errPb.Msg,
)
}
}
case err := <-push.errCh:
Expand Down