Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[cherry-pick] backup: more detailed TiKV error message(tidb#27567) #1444

Merged

Conversation

YuJuncen
Copy link
Collaborator

cherry-picking tidb#27567

===

What problem does this PR solve?

Problem Summary:

The error information when meeting unknown TiKV storage error is too abstract...

What is changed and how it works?

What's Changed:
Added more details to the error.

How it Works:
So we can get more detailed information.

Check List

Tests

  • (almost) No code

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@YuJuncen
Copy link
Collaborator Author

/run-integration-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Nov 24, 2021
@fengou1
Copy link
Contributor

fengou1 commented Nov 24, 2021

/LGTM

@ti-chi-bot
Copy link
Member

@fengou1: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@YuJuncen
Copy link
Collaborator Author

/run-integration-tests

@YuJuncen
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

@YuJuncen: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Nov 24, 2021
@kennytm
Copy link
Collaborator

kennytm commented Nov 24, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: caba877

@ti-chi-bot ti-chi-bot merged commit e1b36e7 into pingcap:release-4.0 Nov 24, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.16 milestone Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants