Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Print error log into log file instead of terminal (#1355) #1358

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1355

What problem does this PR solve?

Fix log print

What is changed and how it works?

log print into log file instead of terminal

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this cherrypicking 2 PRs together though 🤔

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jul 16, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • zwj-coder

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@kennytm
Copy link
Collaborator

kennytm commented Jul 23, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: c4cba9c

@ti-chi-bot ti-chi-bot added size/XS and removed size/M labels Jul 23, 2021
@ti-chi-bot ti-chi-bot merged commit 1b7c88b into pingcap:release-5.1 Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants