Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Print error log into log file instead of terminal #1355

Merged
merged 7 commits into from
Jul 16, 2021

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Jul 16, 2021

What problem does this PR solve?

Fix log print

What is changed and how it works?

log print into log file instead of terminal

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jul 16, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jul 16, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Jul 16, 2021

/merge

@ti-chi-bot
Copy link
Member

@fengou1: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ZipFast
Copy link
Contributor

ZipFast commented Jul 16, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 580a3c7

@fengou1
Copy link
Contributor Author

fengou1 commented Jul 16, 2021

/needs-cherry-pick-release-5.1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1356.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1357.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1358.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants