Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

action trigger: fix issue #1167, compatibility trigger bug on push #1170

Merged
merged 5 commits into from
Jun 3, 2021
Merged

action trigger: fix issue #1167, compatibility trigger bug on push #1170

merged 5 commits into from
Jun 3, 2021

Conversation

Leavrth
Copy link
Collaborator

@Leavrth Leavrth commented Jun 2, 2021 •
edited
Loading

What problem does this PR solve?

fix #1167
push trigger
- uses: khan/pull-request-comment-trigger@master
id: check
with:
trigger: '/run-compatiblility-tests'
which is error because it needs pull_request.body. see
https://github.com/Khan/pull-request-comment-trigger/blob/master/dist/index.js#L10698

What is changed and how it works?

trigger /run-compatiblility-tests is not used anymore. Just delete the lines above.
Besides, add paths-ignore.

Check List

Related changes

  • Need to cherry-pick to the release branch

Release note

-No release note

@Leavrth
Copy link
Collaborator Author

Leavrth commented Jun 2, 2021

Please add more ignore-paths in comment if in need.

3pointer
3pointer reviewed Jun 2, 2021
View reviewed changes
.github/workflows/compatible_test.yml Outdated Show resolved Hide resolved
.github/workflows/compatible_test.yml Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/M and removed size/S labels Jun 3, 2021
@Leavrth
Copy link
Collaborator Author

Leavrth commented Jun 3, 2021

It seems ensure_tikv sometimes fail, so add sleep 1 as before.
https://ci.pingcap.net/blue/organizations/jenkins/br_ghpr_unit_and_integration_test/detail/br_ghpr_unit_and_integration_test/3767/pipeline

@Leavrth
supplement paths-ignore
8365224 
Signed-off-by: Leavrth <Legenull@gmail.com>
@Leavrth Leavrth mentioned this pull request Jun 3, 2021
Closed
@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jun 3, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jun 3, 2021
@kennytm
Copy link
Collaborator

kennytm commented Jun 3, 2021

do you know why the actions are not running in this PR 🤔

@3pointer
Copy link
Collaborator

3pointer commented Jun 3, 2021 •
edited
Loading

do you know why the actions are not running in this PR 🤔

cause we add path-ignore: in this PR.

@3pointer
Copy link
Collaborator

3pointer commented Jun 3, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8365224

@ti-chi-bot ti-chi-bot merged commit 637c84d into pingcap:master Jun 3, 2021
ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Jun 3, 2021
@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#1170
8bcf327 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 3, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1174.

ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Jun 3, 2021
@Leavrth @ti-chi-bot
This is an automated cherry-pick of pingcap#1170
717d1e0 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1175.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 3, 2021
Merged
3pointer added a commit to 3pointer/br that referenced this pull request Jun 4, 2021
@3pointer
fix default-columns ci
9feee1b 
backup/checksum: add cluster index support for ranges (pingcap#1120)

lightning/restore: support ingset multi ssts for same range (pingcap#1089)

* ingest ssts for the same range in a batch

* make ingest compatible with old tikv

tests: add row count check for br clustered index tests (pingcap#1151)

storage: mkdirAll for local storage even when SkipCheckPath is true (pingcap#1156)

tests/br: fix bug in issue pingcap#1158 (pingcap#1160)

tests/br/compatibility: fix failed for manifest unknown (pingcap#1161)

*: upgrade go version from 1.13/1.15 to 1.16 (pingcap#1159)

action trigger: fix compatibility trigger bug on push (pingcap#1170)

address comment

fix test

address comment

address comment

fix build

add ut for ignore columns

go.mod: update tidb to the new version (pingcap#1153)

lightning: support restore data into tables that contains data (pingcap#784)

fix conflict after merge master
3pointer pushed a commit to 3pointer/br that referenced this pull request Jun 4, 2021
@Leavrth @3pointer
action trigger: fix compatibility trigger bug on push (pingcap#1170)
fa12b02
@Leavrth Leavrth changed the title action trigger: fix compatibility trigger bug on push action trigger: fix issue #11167, compatibility trigger bug on push Jun 7, 2021
@Leavrth Leavrth changed the title action trigger: fix issue #11167, compatibility trigger bug on push action trigger: fix issue #1167, compatibility trigger bug on push Jun 7, 2021
@Leavrth Leavrth linked an issue Jun 7, 2021 that may be closed by this pull request
master branch CI always failed #1167
Closed
@Leavrth Leavrth deleted the br_compatibility_action_trigger_fix branch June 11, 2021 04:20
ti-chi-bot added a commit that referenced this pull request Jun 17, 2021
@ti-chi-bot
action trigger: fix compatibility trigger bug on push (#1170) (#1175)
3b22dff
ti-chi-bot added a commit that referenced this pull request Jun 18, 2021
@ti-chi-bot
action trigger: fix compatibility trigger bug on push (#1170) (#1174)
4d01e6a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@glorv glorv glorv approved these changes

@3pointer 3pointer 3pointer approved these changes

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
component/test needs-cherry-pick-release-4.0 needs-cherry-pick-release-5.0 size/M status/can-merge status/LGT2 LGTM2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

master branch CI always failed
5 participants
@Leavrth @ti-chi-bot @kennytm @3pointer @glorv