Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

tests/br/compatibility: fix failed for manifest unknown #1161

Merged
merged 19 commits into from
Jun 2, 2021
Merged

tests/br/compatibility: fix failed for manifest unknown #1161

merged 19 commits into from
Jun 2, 2021

Conversation

Leavrth
Copy link
Collaborator

@Leavrth Leavrth commented Jun 1, 2021

What problem does this PR solve?

  1. compatibility test failed because there has not been docker image yet for v5.1.0-alpha.
  • TAG=v5.1.0-alpha PORT_SUFFIX=3 docker-compose -p v5.1.0-alpha -f compatibility/backup_cluster.yaml up -d
  • Successfully built 8119b2b49235
  • Successfully tagged control:nightly
  • Successfully built e3e942a2f342
  • Successfully tagged control:nightly
  • TAG=v5.0.1 PORT_SUFFIX=1 docker-compose -p v5.0.1 -f compatibility/backup_cluster.yaml up -d
  • TAG=v4.0.13 PORT_SUFFIX=2 docker-compose -p v4.0.13 -f compatibility/backup_cluster.yaml up -d
  • Creating network "v510-alpha_default" with the default driver
  • Pulling pd0 (pingcap/pd:v5.1.0-alpha)...
  • Creating network "v4013_default" with the default driver
  • Creating network "v501_default" with the default driver
  • Pulling pd0 (pingcap/pd:v4.0.13)...
  • Pulling pd0 (pingcap/pd:v5.0.1)...
  • manifest for pingcap/pd:v5.1.0-alpha not found: manifest unknown: manifest unknown
  • v4.0.13: Pulling from pingcap/pd
  • v5.0.1: Pulling from pingcap/pd`
  1. source compatibility/prepare_backup.sh in tests/run_compatible.sh will trigger prepare shell again, which might be into infinite call loop.

What is changed and how it works?

  1. add file check for restore to skip when prepare is not finished since there is no docker image. just filter alpha tag
  2. move the function getLastestTags() into file compatibility/get_last_tags.sh

Check List

Related changes

  • Need to cherry-pick to the release branch

Release note

-No release note

Signed-off-by: Leavrth <Legenull@gmail.com>
@Leavrth Leavrth marked this pull request as draft June 1, 2021 03:22
Signed-off-by: Leavrth <Legenull@gmail.com>
@ti-chi-bot ti-chi-bot added size/S and removed size/XS labels Jun 1, 2021
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
@ti-chi-bot ti-chi-bot added size/M and removed size/S labels Jun 1, 2021
Leavrth added 13 commits June 1, 2021 15:05
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
Signed-off-by: Leavrth <Legenull@gmail.com>
@Leavrth Leavrth marked this pull request as ready for review June 2, 2021 04:59
@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jun 2, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jun 2, 2021
@glorv
Copy link
Collaborator

glorv commented Jun 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c6764f3

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1168.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1169.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/br#release-4.0 from head ti-chi-bot:cherry-pick-1161-to-release-4.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-1161-to-release-4.0."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/br#release-5.0 from head ti-chi-bot:cherry-pick-1161-to-release-5.0: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-1161-to-release-5.0."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

3pointer added a commit to 3pointer/br that referenced this pull request Jun 4, 2021
backup/checksum: add cluster index support for ranges (pingcap#1120)

lightning/restore: support ingset multi ssts for same range (pingcap#1089)

* ingest ssts for the same range in a batch

* make ingest compatible with old tikv

tests: add row count check for br clustered index tests (pingcap#1151)

storage: mkdirAll for local storage even when SkipCheckPath is true (pingcap#1156)

tests/br: fix bug in issue pingcap#1158 (pingcap#1160)

tests/br/compatibility: fix failed for manifest unknown (pingcap#1161)

*: upgrade go version from 1.13/1.15 to 1.16 (pingcap#1159)

action trigger: fix compatibility trigger bug on push (pingcap#1170)

address comment

fix test

address comment

address comment

fix build

add ut for ignore columns

go.mod: update tidb to the new version (pingcap#1153)

lightning: support restore data into tables that contains data (pingcap#784)

fix conflict after merge master
@Leavrth Leavrth deleted the br_compatibility_fix branch June 11, 2021 04:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants