Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI configuration, add pre-commit #39

Merged
merged 10 commits into from
Dec 1, 2022

Conversation

kristinazvolanek
Copy link
Contributor

Closes #

Draft PR for updating circle CI and adding pre-commit.

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.

  • [Code or tests only] I wrote/updated the necessary docstrings.

  • [Code or tests only] I ran and passed tests locally.

  • [Documentation only] I built the docs locally.

  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.

  • My code respects the adopted style, especially linting conventions.

  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.

  • I added or indicated the right labels.

  • I added information regarding the timeline of completion for this PR.

  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia changed the title Switch CI to CircleCI, add pre-commit Update CircleCI configuration, add pre-commit Dec 1, 2022
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll commit to your branch some changes!

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@772ab8e). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #39   +/-   ##
=========================================
  Coverage          ?   43.52%           
=========================================
  Files             ?        7           
  Lines             ?      301           
  Branches          ?        0           
=========================================
  Hits              ?      131           
  Misses            ?      170           
  Partials          ?        0           

@kristinazvolanek kristinazvolanek marked this pull request as ready for review December 1, 2022 17:08
@smoia smoia merged commit 26211fb into physiopy:master Dec 1, 2022
@kristinazvolanek kristinazvolanek deleted the switch_ci branch December 1, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants