Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to CircleCI, drop Windows testing #430

Merged
merged 6 commits into from
Nov 29, 2022

Conversation

smoia
Copy link
Member

@smoia smoia commented Nov 29, 2022

Closes #

Proposed Changes

  • Leaving Cirrus CI in favour of Circle CI due to the intensive use of credits
  • Also dropping testing for Windows, at least for the moment, as they take too many credits to be a sustainable support.

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@smoia smoia added Testing This is for testing features, writing tests or producing testing code Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog labels Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #430 (f39f937) into master (68f3f42) will not change coverage.
The diff coverage is n/a.

❗ Current head f39f937 differs from pull request most recent head e377344. Consider uploading reports for the commit e377344 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files           8        8           
  Lines         879      879           
=======================================
  Hits          830      830           
  Misses         49       49           

@smoia smoia merged commit 72ffc15 into physiopy:master Nov 29, 2022
@smoia smoia deleted the int/switch_ci branch November 29, 2022 11:01
@smoia smoia restored the int/switch_ci branch November 29, 2022 11:01
@smoia smoia deleted the int/switch_ci branch November 29, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog Testing This is for testing features, writing tests or producing testing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant