Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add score to hard-coded Mus #83

Merged
merged 2 commits into from
Jun 17, 2023
Merged

Conversation

fmichonneau
Copy link
Contributor

Hello,

I'm preparing a new release for rotl which includes a "breaking change". The output of the the tnrs_match_names now includes a new column called score. When there are multiple matches in OTL for a taxon, tnrs_match_names always returns the taxa with the highest score.

Given that the datelife code hardcodes the format of the tnrs_match_names output, I included this score for the Mus.

With this fix, the vignettes now build but I haven't tested if there are other side effects.

Thanks!

@LunaSare
Copy link
Member

LunaSare commented Jun 13, 2023

Thanks for the pull request @fmichonneau! the tests are failing now, but it's because the new rotl is not released yet, I'll be on the lookout.

I'll check if there are any other places that could be affected by the new score column. Also, we might not need to hard code Mus no more. I'll investigate.

@fmichonneau
Copy link
Contributor Author

fmichonneau commented Jun 15, 2023

Thanks @LunaSare. I updated the PR slightly to accommodate older rotl versions. The alternative would be to add rotl >= 3.1.0 in your DESCRIPTION. I'm going to submit rotl 3.1.0 to CRAN today.

@fmichonneau
Copy link
Contributor Author

rotl is now on CRAN so you can expect a message from them asking for a new datelife submission soon. Thanks!

@LunaSare
Copy link
Member

Thanks @fmichonneau! This is a very clever fix. I'll pull your changes, we just need to change the version number to character in the comparison if (packageVersion("rotl") >= 3.1.0, because version numbers are not really numeric, so the "larger than or equals to" comparison fails. This will do if (packageVersion("rotl") >= "3.1.0"
I received the message from CRAN, so I can do that!

@LunaSare LunaSare merged commit e4a9f53 into phylotastic:master Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants