Feature: Add FileAssembler #250

icanhazstring · 2019-06-17T19:07:32Z

This will add the ability to give your generated files declare(strict_types=1);.

This depends on a feature in zend-code being merged and tagged. Currently its not possible to generate a file with declare() statements. So the build will probably fail with the tests since the needed method is not there.
zendframework/zend-code#169

I hope I found everything that has to be updated (docs, tests etc). If something is missing
or should be changed. Let me know.

…onse.body` (#1) `Phpro\SoapClient\Soap\Driver\ExtSoap\AbusedClient::doActualRequest()` doesn't set `$this->__last_response` so `Phpro\SoapClient\Client::debugLastSoapRequest()` returns empty `response.body`

This will add the ability to add script_types declare statement into the generated file.

veewee

Thanks for the PR!
Looks like a nice addition. I added a couple of small remarks.
Of course we won't merge it in before the feature is available in zend-code. :)

veewee · 2019-06-18T07:30:30Z

docs/code-generation/assemblers.md

+
+## FileAssembler
+
+The `FileAssembler` is able to add `declare()` statements into generated files.


Since it adds a declare statement, wouldn't it be better to name it DeclareAssembler ?

I choose FileAssembler because there is also the ability to require files if you need to.
Or do other stuff inside the file, which is not strictly limited to class, namespace or use.

DeclareAssembler would only be a single usage limited to declare

I discussed this with @janvernieuwe : the purpose of the assemblers in this package is to do one tiny change to a file.
It seems like a better idea to go for a DeclareAssembler and add other assemblers when needed.
That way the assembler doesn't get bloated if we add additional features on file level + you can easily add the assemblers you want to use in your config instead of adding tons of options to one assembler.

Alright. Got it. Will rename it then :)

src/Phpro/SoapClient/CodeGenerator/Assembler/FileAssemblerOptions.php

src/Phpro/SoapClient/CodeGenerator/Context/FileContext.php

test/PhproTest/SoapClient/Unit/CodeGenerator/Assembler/FileAssemblerTest.php

veewee · 2019-06-18T07:37:29Z

docs/code-generation/assemblers.md

+}
+```
+
+## FileAssembler


Maybe a good idea to add the version of zend-code in which this feature will be released?

I updated the composer.json with the next possible version where this will be included (which should be ^3.4), This will obviously break the build even more ;)

We'll also have to update some additional files (since we are not shipping the code generation in a separate package atm). In here we hardcoded the version of zend-code.

README.md

docs/code-generation/assemblers.md

docs/cli/generate-client.md

docs/cli/generate-types.md

docs/cli/generate-classmap.md

src/Phpro/SoapClient/Console/Event/Subscriber/ZendCodeValidationSubscriber.php

Alright, thanks. Will update them as well

This requires the minimum required version of zend-code with the needed implementations for FileAssembler to work

PHPStan level 4

#252

call cleanUpTemporaryState() if SoapFault is thrown in __soapCall fixes #252

Also cleanup temporary encoder state on failure

icanhazstring · 2019-10-06T04:57:40Z

@veewee zend-code was just updated to 3.4.0. So the feature is now available.

veewee · 2019-10-10T10:52:20Z

Great to hear @icanhazstring.
I've re-ran the tests and they return as broken. Besides that, there were some unresolved code comments.
Feel free to pick it up if you have the space to do so.

icanhazstring · 2019-10-10T10:56:40Z

Yep, will update the feature PR as soon as I find the time :)
Also the renaming, which was noted, wasn't done yet. So still some work to do :)

WSSE Make sure BinarySecurityToken is singed as well

Fixes #258

Fix getClass issue due to bad return types

Rename engine factory

Use stable php-soap and veewee/xml

V2.0.0

PHP 8.1 Compatibility

Fixes #337

Don't import known types

Fixes rules.md documentation

Use real type of iterator return value type hint

This fixes the new deprecation warnings in PHP 8.1.

Use return types from JsonSerializable/IteratorAggregate (fixes PHP 8.1 deprecations)

Fix phpspec on PHP81

Fixes #429

Allow all currently available versions of psr/log

Fix typo in readme.md

…to file-assembler # Conflicts: # composer.json # src/Phpro/SoapClient/CodeGenerator/ConfigGenerator.php # src/Phpro/SoapClient/CodeGenerator/TypeGenerator.php Updated FileAssembler

janvernieuwe · 2022-09-30T13:36:24Z

Closed in favor of #450

hshhhhh and others added 2 commits June 10, 2019 21:45

Phpro\SoapClient\Client::debugLastSoapRequest() returns empty `resp…

8ef0dd0

…onse.body` (#1) `Phpro\SoapClient\Soap\Driver\ExtSoap\AbusedClient::doActualRequest()` doesn't set `$this->__last_response` so `Phpro\SoapClient\Client::debugLastSoapRequest()` returns empty `response.body`

Add FileAssembler

afe6dbf

This will add the ability to add script_types declare statement into the generated file.

veewee reviewed Jun 18, 2019

View reviewed changes

veewee added the new feature label Jun 18, 2019

Andreas Frömer and others added 16 commits June 18, 2019 14:06

Add spec tests

17fd4c9

Update zend-code minimum version

be87a6a

This requires the minimum required version of zend-code with the needed implementations for FileAssembler to work

Update test implementation

ff8d972

Merge branch 'master' into feature/fileassembler

3b516a9

PHPStan level 4

7fd1724

Update psr/http-message dependency requirements

963b349

Process review comments

8244032

Process review comments

5e3490d

Merge pull request #251 from janvernieuwe/phpstan-next-level

7abfc60

PHPStan level 4

call cleanUpTemporaryState() if SoapFault is thrown in __soapCall

fea5573

call cleanUpTemporaryState() if SoapFault is thrown in __soapCall fixes

9abaffe

#252

Merge branch 'master' of github.com:lukastaferner/soap-client

11d4956

Use finally. Thanks to @janvernieuwe for the hint.

dd7bb7d

Merge pull request #253 from lukastaferner/master

2e65a9e

call cleanUpTemporaryState() if SoapFault is thrown in __soapCall fixes #252

Also cleanup temporary encoder state on failure

aaa4d3c

Merge pull request #255 from veewee/encode-cleanup

84ea6c5

Also cleanup temporary encoder state on failure

veewee and others added 7 commits October 13, 2019 13:34

Make sure BinarySecurityToken is singed as well

a75c1fc

Merge pull request #257 from veewee/wsse-sign-binary-token

42a39af

WSSE Make sure BinarySecurityToken is singed as well

Fix getClass issue due to bad return types

5ec8941

Fixes #258

Merge pull request #259 from janvernieuwe/issue-258

edb99c5

Fix getClass issue due to bad return types

remove decrecaptions for Symfony 4

2a07f6d

fix phpcs

467a30c

fix backward compatibility

f03c884

veewee and others added 27 commits September 24, 2021 07:28

Provide a better name for the default engine factory

008490a

Merge pull request #389 from veewee/rename-engine-factory

c2a820d

Rename engine factory

Remove invalid code

1f8cb9c

Use stable php-soap and veewee/xml

d64e4e7

Merge pull request #390 from veewee/v2-deps

caa8a96

Use stable php-soap and veewee/xml

Finetune wording

72055ff

Merge pull request #391 from phpro/v2.0.0

662dce2

V2.0.0

PHP 8.1 Compatibility

cc141b3

Merge pull request #400 from veewee/php81

bd50f35

PHP 8.1 Compatibility

Don't import known types

426a315

Fixes #337

Merge pull request #406 from janvernieuwe/issue/377

702eb92

Don't import known types

docs: change MetadataInterface to Metadata on rules.md

6884057

docs: fix MultiRule example on rules.md

85a66da

Merge pull request #407 from xthiago/fix-rules-doc

ed1cea5

Fixes rules.md documentation

Use real type of iterator return value type hint

17daec3

Update test

e87d1a4

Merge pull request #408 from sippsolutions/array-type-hint

159d890

Use real type of iterator return value type hint

Use return types from JsonSerializable/IteratorAggregate

f53c9b2

This fixes the new deprecation warnings in PHP 8.1.

Merge pull request #415 from edudobay/php81_return_types

e47ea71

Use return types from JsonSerializable/IteratorAggregate (fixes PHP 8.1 deprecations)

Fix phpspec on PHP81

34e6765

Merge pull request #422 from veewee/phpspec

3310333

Fix phpspec on PHP81

Allow all currently available versions of psr/log

3a0afee

Fixes #429

Merge pull request #430 from rimas-kudelis/patch-1

8f6fc68

Allow all currently available versions of psr/log

Fix typo in readme.md

cf680d6

Merge pull request #441 from borisson/patch-1

9c616b6

Fix typo in readme.md

Merge remote-tracking branch 'icanhazstring/feature/fileassembler' in…

bd39123

…to file-assembler # Conflicts: # composer.json # src/Phpro/SoapClient/CodeGenerator/ConfigGenerator.php # src/Phpro/SoapClient/CodeGenerator/TypeGenerator.php Updated FileAssembler

Update composer

d1c50e9

janvernieuwe mentioned this pull request Sep 30, 2022

StrictTypesAssember #450

Merged

janvernieuwe closed this Sep 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Add FileAssembler #250

Feature: Add FileAssembler #250

icanhazstring commented Jun 17, 2019 •

edited

Loading

veewee left a comment

veewee Jun 18, 2019

icanhazstring Jun 18, 2019

veewee Jun 21, 2019

icanhazstring Jun 21, 2019

veewee Jun 18, 2019

icanhazstring Jun 18, 2019 •

edited

Loading

veewee Jun 21, 2019

icanhazstring Jun 21, 2019

icanhazstring commented Oct 6, 2019 •

edited

Loading

veewee commented Oct 10, 2019

icanhazstring commented Oct 10, 2019

janvernieuwe commented Sep 30, 2022


		## FileAssembler

		The `FileAssembler` is able to add `declare()` statements into generated files.

Feature: Add FileAssembler #250

Feature: Add FileAssembler #250

Conversation

icanhazstring commented Jun 17, 2019 • edited Loading

veewee left a comment

Choose a reason for hiding this comment

veewee Jun 18, 2019

Choose a reason for hiding this comment

icanhazstring Jun 18, 2019

Choose a reason for hiding this comment

veewee Jun 21, 2019

Choose a reason for hiding this comment

icanhazstring Jun 21, 2019

Choose a reason for hiding this comment

veewee Jun 18, 2019

Choose a reason for hiding this comment

icanhazstring Jun 18, 2019 • edited Loading

Choose a reason for hiding this comment

veewee Jun 21, 2019

Choose a reason for hiding this comment

icanhazstring Jun 21, 2019

Choose a reason for hiding this comment

icanhazstring commented Oct 6, 2019 • edited Loading

veewee commented Oct 10, 2019

icanhazstring commented Oct 10, 2019

janvernieuwe commented Sep 30, 2022

icanhazstring commented Jun 17, 2019 •

edited

Loading

icanhazstring Jun 18, 2019 •

edited

Loading

icanhazstring commented Oct 6, 2019 •

edited

Loading