Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtSoapDecoder fails to cleanUpTemporaryState on SoapFault Exception #252

Closed
lukastaferner opened this issue Jul 29, 2019 · 1 comment
Closed

ExtSoapDecoder fails to cleanUpTemporaryState on SoapFault Exception #252

lukastaferner opened this issue Jul 29, 2019 · 1 comment

Comments

@lukastaferner
Copy link
Contributor

Bug Report

Q A
Version 1.0.3

Summary

\Phpro\SoapClient\Soap\Driver\ExtSoap\ExtSoapDecoder fails to call cleanUpTemporaryState() if a SoapFault Exception in __soapCall is thrown. The next SOAPcall will not contact the server but return the stored (faulty) response.

How to reproduce

Produce a SOAPFault and re-send the request in the same thread. You need to restart thread to clear the cache

Expected behavior

The Exception should be cought, and the temporary state should be cleared.
@veewee veewee closed this as completed in 9abaffe Aug 2, 2019
veewee added a commit that referenced this issue Aug 2, 2019
@veewee
Merge pull request #253 from lukastaferner/master
2e65a9e 
call cleanUpTemporaryState() if SoapFault is thrown in __soapCall fixes #252
@veewee veewee mentioned this issue Aug 2, 2019
Merged
@veewee
Copy link
Contributor

veewee commented Aug 2, 2019

Thanks for reporting and fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@veewee @lukastaferner