Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed type Void as this is a reserved classname keyword in PHP 7.1 #20

Closed
wants to merge 1 commit into from
Closed

Renamed type Void as this is a reserved classname keyword in PHP 7.1 #20

wants to merge 1 commit into from

Conversation

jpauli
Copy link

@jpauli jpauli commented Jun 9, 2016

Testing Symfony with PHP 7.1 :

Fatal error: Cannot use 'Void' as class name as it is reserved in /home/jpauli/www/symfony/Symfony/vendor/phpdocumentor/type-resolver/src/Types/Void.php on line 23

@GrahamCampbell
Copy link
Contributor

@jpauli Your PR doesn't seem to work, and we already have a working one at #18.

@jpauli
Copy link
Author

jpauli commented Jun 9, 2016

Ah OK, feel free to close it and merge whatever one works for you then ;-)

@mvriel
Copy link
Member

mvriel commented Jun 10, 2016

Hi @jpauli, thanks for the contribution. Unfortunately #18 was issued prior with the same type of fixes. I am going to close this PR in favor of #18

@mvriel mvriel closed this Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants