Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Void to Void_ since it is a reserved keyword in PHP7.1 #18

Merged
merged 2 commits into from
Jun 10, 2016
Merged

Rename Void to Void_ since it is a reserved keyword in PHP7.1 #18

merged 2 commits into from
Jun 10, 2016

Conversation

hboomsma
Copy link

@hboomsma hboomsma commented Jun 8, 2016

Fixing the followint failure:

1) phpDocumentor\Reflection\TypeResolverTest::testResolvingKeywords with
data set #15 ('void', 'phpDocumentor\Reflection\Types\Void')
PHPUnit_Framework_Exception: Argument #1 (No Value) of
PHPUnit_Framework_Assert::assertInstanceOf() must be a class or
interface name

This is a BC break
phpDocumentor/ReflectionDocBlock#75 updated phpDocumentor/ReflectionDocBlock accordingly. If other packages need an update too, please let me know, I'm happy to help.

Hidde Boomsma added 2 commits June 8, 2016 09:52
Fixing the followint failure:

1) phpDocumentor\Reflection\TypeResolverTest::testResolvingKeywords with
data set #15 ('void', 'phpDocumentor\Reflection\Types\Void')
PHPUnit_Framework_Exception: Argument #1 (No Value) of
PHPUnit_Framework_Assert::assertInstanceOf() must be a class or
interface name
@GrahamCampbell
Copy link
Contributor

👍

@mvriel
Copy link
Member

mvriel commented Jun 10, 2016

Hi @hboomsma,

Thank you for your contribution; it is awesome to see that people use this library even in really up to date versions of PHP (or preparing for it) and it is even more awesome to see contributions like these to help ensure this works.

I have just merged the pull request and tagged a new version of the library

@mvriel mvriel merged commit b39c7a5 into phpDocumentor:master Jun 10, 2016
@hboomsma hboomsma deleted the feature/php71_compat branch June 10, 2016 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants