Parallel jobs with make #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM :) |
theofidry
reviewed
Oct 25, 2024
| * | ||
| * @return positive-int | ||
| */ | ||
| public static function determine(): int |
There was a problem hiding this comment.
I recommend https://github.com/theofidry/cpu-core-counter, its the code used in most tools which have parallelisation
There was a problem hiding this comment.
Some great packages already used it : see https://packagist.org/packages/fidry/cpu-core-counter/dependents?order_by=downloads
And I hope (me too) to adapt some of my packages to add a parallelization feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73
PIE will try three approaches to determine the number of cores (
nproc --all,getconf __NPROCESSORS_ONLN,sysctl -n hw.ncpu), or you can override with-jNor--make-parallel-jobs=Nwhen running with PIE.Doesn't cover Windows; or maybe some uncommon systems without those above commands. Suggestions welcome.