Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust timeouts for invoked processes #75

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Oct 24, 2024

Fixes #72

Defaulted to 5s for all commands executed, except:

  • phpize - 1 minute
  • ./configure - 2 minutes
  • make - 10 minutes
  • make install - 1 minute

I think these are reasonable maximums, but we can adjust accordingly with the constants defined going forward, should we need to.

@asgrim asgrim added the bug Something isn't working label Oct 24, 2024
@asgrim asgrim added this to the 0.1.1 milestone Oct 24, 2024
@asgrim asgrim merged commit c80f425 into php:main Oct 24, 2024
19 checks passed
@asgrim asgrim deleted the adjust-timeouts-for-process-invokations branch October 24, 2024 09:58
@asgrim asgrim modified the milestones: 0.1.1, 0.2.0 Oct 24, 2024
@remicollet
Copy link
Member

make - 10 minutes

This seems short to me
Try ones of grpc, couchbase or datadog_trace on a slow computer (especially without -j option, see #73)

@asgrim
Copy link
Collaborator Author

asgrim commented Oct 24, 2024

make - 10 minutes

This seems short to me Try ones of grpc, couchbase or datadog_trace on a slow computer (especially without -j option, see #73)

Would you be able to suggest a safer limit please?

@remicollet
Copy link
Member

Would you be able to suggest a safer limit please?

No, IMHO, this should be unlimited
Even if quite confusing, especially because of no output by default.

For me, "stalled" means no output for a few minutes (build are usually very verbose), nothing related to the whole process duration.

@asgrim
Copy link
Collaborator Author

asgrim commented Oct 24, 2024

Thanks - I've adjusted it to be unlimited in #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The process "'make'" exceeded the timeout of 60 seconds
2 participants