Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pipfile #290

Merged
merged 3 commits into from
Sep 18, 2021
Merged

Update Pipfile #290

merged 3 commits into from
Sep 18, 2021

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Sep 15, 2021

the search on readthedocs is broken and there is a jquery error when loading the page.

we seem to use very old versions of sphinx and its dependencies. lets see if upgrading helps.

fix #289

@Xenonym
Copy link
Contributor

Xenonym commented Sep 16, 2021

@dbu I don't think the CI process is working. Is Travis even required? The last PR I made (#288) seem to deploy just fine.

The ability to preview changes doesn't seem to be tied to Travis either - having this enabled would cover most of the needs for having a CI process in a documentation project like this.

@dbu
Copy link
Contributor Author

dbu commented Sep 16, 2021

thanks, i managed to make readthedocs build the branch. it seems to build with these changes, but the search is still broken: https://php-http--290.org.readthedocs.build/en/290/

the log of the build seems to be here: https://readthedocs.org/api/v2/build/14728001.txt

if you have any idea, i appreciate input. otherwise i will try to look into it but can't promise when i get to it.

@Xenonym
Copy link
Contributor

Xenonym commented Sep 17, 2021

@dbu RTD is using requirements.txt instead of Pipfile and defaulting to Python 2:

[rtd-command-info] start-time: 2021-09-16T06:28:20.743105Z, end-time: 2021-09-16T06:28:25.838423Z, duration: 5, exit-code: 0
/home/docs/checkouts/readthedocs.org/user_builds/php-http/envs/290/bin/python -m pip install --exists-action=w --no-cache-dir -r requirements.txt
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.

It doesn't seem like RTD has ever supported Pipenv from the start: readthedocs/readthedocs.org#3181

The version of PIP used in RTD should support Poetry via PEP 517, if you are so inclined, or we could just use requirements.txt and specify Python 3 in .readthedocs.yaml for simplicity.

@dbu dbu force-pushed the update-sphinx branch 2 times, most recently from 7cf741c to e9b6e08 Compare September 18, 2021 12:27
@dbu dbu force-pushed the update-sphinx branch 2 times, most recently from 593faf8 to 9cbc11f Compare September 18, 2021 13:08
@dbu dbu merged commit 22af083 into master Sep 18, 2021
@dbu dbu deleted the update-sphinx branch September 18, 2021 13:32
@dbu
Copy link
Contributor Author

dbu commented Sep 18, 2021

thanks for the ping-pong! i think i found a working solution with recent versions of the stuff. and the search seems fixed \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation search does not work
2 participants