Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link to PSR-18 in index #288

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Fix broken link to PSR-18 in index #288

merged 1 commit into from
Sep 15, 2021

Conversation

Xenonym
Copy link
Contributor

@Xenonym Xenonym commented Sep 14, 2021

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
Documentation n/a
License MIT

What's in this PR?

index.rst refers to a link to PSR-18, but does not actually provide that link.

Let's:

  • move the link to PSR-18 to the epilog so that both discovery.rst and index.rst link to PSR-18 properly
  • change the link to PSR-17 to HTTPS, because it's 2021 :p

Why?

Link's broken, gotta fix it.

index.rst refers to a link to PSR-18, but does not actually provide that
link.

Let's:

- move the link to PSR-18 to the epilog so that both discovery.rst and
   index.rst link to PSR-18 properly

- change the link to PSR-17 to HTTPS, because it's 2021 :p
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@dbu dbu merged commit 7e368e8 into php-http:master Sep 15, 2021
@Xenonym Xenonym deleted the fix/broken-psr18-link branch September 15, 2021 07:01
@Xenonym Xenonym mentioned this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants