-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhET-iO instrumentation for GrabDragInteraction #720
Comments
@zepumph there needs to be a way to disable the GrabDragInteraction pressListener. Otherwise, you can do something like set |
I added an enabledProperty to GrabDragInteraction. It mimics the opt-in approach used in PressListener/DragListener. This doesn't directly address the concern you had in #720 (comment). This is because of how inputEnabled is set up to work. That doesn't block focus events at this time. I created phetsims/scenery#1369 to discuss this more. |
For right now, please go to |
Hide the grab cue when inputEnabled is false. |
Alright. I have updated the cues to hide if inputEnabled:false. @arouinfar would you please take another look at this? Close if all is well. |
Thanks @zepumph, I've confirmed that the cues are hidden when |
Reopening. I think it would be much nicer if toggling inputEnabled on the micro view just changed the grabDragInteraction itself. This means that we can simplify this grab drag interaction instrumentation by making it phetioReadOnly in general. Why would someone want to turn off the keyboard input while keeping other input on? That doesn't seem like the granularity to support. |
Actually, I'll just have this work done over in phetsims/friction#285, but will reference over here. |
From phetsims/friction#236 (comment), it would be good to understand if there is anything to add to the interoperability. In general, I feel like this isn't. A design meeting may be nice though.
The text was updated successfully, but these errors were encountered: