-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With drag input disabled, cue arrows return after reset all #333
Comments
…, rename dragArea=>atomDragArea, rearrange order of child creation, see #333
@matthew-blackman and I collaborated on this issue, and we believe the fix is working correctly. We tested in studio, trying various combinations of inputEnabledProperty and hint visible property. All seems well, let's request review from @zepumph , then if it seems OK this can be ready for cherry-picking. |
That looks excellent! Thanks. I see that toggling the macro book doesn't change the arrows. I think that is right because you can still move the micro view separately. So the arrows are just tied to the micro view.
The functionality works well. Ready for cherry pick. |
…, rename dragArea=>atomDragArea, rearrange order of child creation, see #333
Cherry-pick done above, and I confirmed in 1.6 SHAs that if you make |
Looks good in rc.3 |
For phetsims/qa#886
Related to phetsims/scenery-phet#720 (comment)
When
friction.frictionScreen.view.atomicView.atomDragArea.inputEnabledProperty
is set to false, the cue arrows are hidden. However,friction.frictionScreen.view.atomicView.hintArrowsNode.visibleProperty
remains true, and the arrows return after reset all.The text was updated successfully, but these errors were encountered: