Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With drag input disabled, cue arrows return after reset all #333

Closed
Tracked by #899
stemilymill opened this issue Jan 31, 2023 · 4 comments
Closed
Tracked by #899

With drag input disabled, cue arrows return after reset all #333

stemilymill opened this issue Jan 31, 2023 · 4 comments

Comments

@stemilymill
Copy link

stemilymill commented Jan 31, 2023

For phetsims/qa#886

Related to phetsims/scenery-phet#720 (comment)

When friction.frictionScreen.view.atomicView.atomDragArea.inputEnabledProperty is set to false, the cue arrows are hidden. However, friction.frictionScreen.view.atomicView.hintArrowsNode.visibleProperty remains true, and the arrows return after reset all.

samreid added a commit that referenced this issue Feb 1, 2023
…, rename dragArea=>atomDragArea, rearrange order of child creation, see #333
@samreid
Copy link
Member

samreid commented Feb 1, 2023

@matthew-blackman and I collaborated on this issue, and we believe the fix is working correctly. We tested in studio, trying various combinations of inputEnabledProperty and hint visible property. All seems well, let's request review from @zepumph , then if it seems OK this can be ready for cherry-picking.

@zepumph
Copy link
Member

zepumph commented Feb 1, 2023

That looks excellent! Thanks.

I see that toggling the macro book doesn't change the arrows. I think that is right because you can still move the micro view separately. So the arrows are just tied to the micro view.

friction.frictionScreen.view.topBookNode.inputEnabledProperty

The functionality works well.

Ready for cherry pick.

@zepumph zepumph removed their assignment Feb 1, 2023
jessegreenberg pushed a commit that referenced this issue Feb 7, 2023
…, rename dragArea=>atomDragArea, rearrange order of child creation, see #333
@jessegreenberg
Copy link
Contributor

Cherry-pick done above, and I confirmed in 1.6 SHAs that if you make friction.frictionScreen.view.atomicView.hintArrowsNode.visibleProperty visible: false, the arrows do not return after pressing reset-all.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 9, 2023

Looks good in rc.3

@KatieWoe KatieWoe closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants