Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multitouch #72

Open
chrisklus opened this issue Nov 11, 2019 · 5 comments
Open

Support multitouch #72

chrisklus opened this issue Nov 11, 2019 · 5 comments

Comments

@chrisklus
Copy link
Contributor

chrisklus commented Nov 11, 2019

For phetsims/number-play#4 and phetsims/number-play#5.

I figured out and fixed what I hope is the last way to achieve a mismatch of values on the Ten and Twenty screen when using just a single input method, like a mouse. As the sim continued to fail fuzz testing after this fix, I realized there are a bunch of multi-touch cases that are not being handled correctly. I was able to reproduce several of these on my phone to confirm.

For now, I'm adding guards in key places relating to the Object and Ones that won't fix the multi-touch cases, but they'll keep the current number from going above or below its given range. Hopefully the sim does better on CT with these additions.

In order to (properly) pass fuzz testing, this sim will need to support all multitouch cases. I don't think that's currently a priority, which is why I'm adding the guards mentioned above. I marked them with TODOs that link to this issue.

@chrisklus chrisklus self-assigned this Nov 11, 2019
chrisklus referenced this issue in phetsims/number-play Nov 11, 2019
…s, make recreated paper ones not pickable, add guards when setting/reading currentNumberProperty, see #2, #4, #5, #6
@chrisklus
Copy link
Contributor Author

@ariel-phet can you confirm the new screens are higher priority than multitouch, or comment if otherwise?

@chrisklus chrisklus assigned ariel-phet and unassigned chrisklus Nov 11, 2019
@ariel-phet
Copy link

Yes, new screens definitely higher priority than multitouch

@pixelzoom
Copy link
Contributor

Deferred, will not be addressed in next publication.

@chrisklus
Copy link
Contributor Author

Also noting that I think this is pretty well supported as is. There hasn't been extensive testing yet, so this issue is not ready to close, but definitely in a far more usable state than when it was created.

@chrisklus chrisklus removed their assignment Apr 26, 2023
@chrisklus chrisklus transferred this issue from phetsims/number-play Jun 1, 2023
@chrisklus
Copy link
Contributor Author

In the above commit I removed number-play and number-compare from multitouch fuzzing so these sims stop lighting up CT while not under development.

  • When multitouch is fixed and supported, add them back in for multitouch testing in listContinuousTests.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants