Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code sprint #2

Closed
chrisklus opened this issue Oct 11, 2019 · 3 comments
Closed

code sprint #2

chrisklus opened this issue Oct 11, 2019 · 3 comments
Assignees
@chrisklus

Comments

@chrisklus
Copy link
Contributor

chrisklus commented Oct 11, 2019 •
edited
Loading

@chrisklus is doing a code sprint during the week of 10/10-10/16.

Sim design doc: https://docs.google.com/document/d/1F9JH-TojXljZVgRgY9lAN78Wujr2b7iLBN9KJpfUJUg/edit
@chrisklus chrisklus self-assigned this Oct 11, 2019
chrisklus added a commit that referenced this issue Oct 11, 2019
@chrisklus
Set up screen structure, see #2
c83f428
chrisklus added a commit that referenced this issue Oct 11, 2019
@chrisklus
Setup hierarchy to common directory, see #2
531f9cd
chrisklus added a commit that referenced this issue Oct 11, 2019
@chrisklus
Update author annotations and headers for base files, see #2
6532415
chrisklus added a commit that referenced this issue Oct 11, 2019
@chrisklus
Set screen background colors, see #2
15128ff
chrisklus added a commit that referenced this issue Oct 11, 2019
@chrisklus
Add the model Property and parametrize both screens, see #2
6c3eeed
chrisklus added a commit that referenced this issue Oct 11, 2019
@chrisklus
Add the top three accordion boxes, see #2
965146d
chrisklus added a commit that referenced this issue Oct 11, 2019
@chrisklus
Remove unneeded screen-specific model and screen view sub-classes, see …
aa4c10b 
…#2
chrisklus added a commit that referenced this issue Oct 11, 2019
@chrisklus
Update model and screen view description, see #2
e1c6dd3
chrisklus added a commit that referenced this issue Oct 11, 2019
@chrisklus
Add options to the ScreenView, unify accordion box naming, see #2
8a3144a
chrisklus added a commit that referenced this issue Oct 12, 2019
@chrisklus
Style accordion box title nodes, see #2
e2ceeeb
chrisklus added a commit that referenced this issue Oct 12, 2019
@chrisklus
Add the ones and objects accordion boxes, see #2
aff04b9
chrisklus added a commit that referenced this issue Oct 12, 2019
@chrisklus
Define terminology and constants for all accordion box sizing, see #2
b4a7a9b
chrisklus added a commit that referenced this issue Oct 12, 2019
@chrisklus
Refactor accordion box sizing, polish accordion box layout, see #2
43270bf
chrisklus added a commit that referenced this issue Oct 12, 2019
@chrisklus
Add expandedProperties to all accordion boxes, see #2
0fa1024
chrisklus added a commit that referenced this issue Oct 14, 2019
@chrisklus
Convert to config pattern, add content to NumberAccordionBox, add con…
66653ef 
…tent to NumeralAccordionBox, see #2
chrisklus added a commit that referenced this issue Oct 14, 2019
@chrisklus
More config refactor, add asserts for config fields, see #2
3133211
chrisklus added a commit that referenced this issue Oct 14, 2019
@chrisklus
Tweak content positioning, see #2
d980b64
chrisklus added a commit that referenced this issue Oct 15, 2019
@chrisklus
Add the ten frames, see #2
7a5c408
chrisklus added a commit that referenced this issue Oct 15, 2019
@chrisklus
Tweak position of written numbers on twenty screen, see #2
4075bcb
chrisklus added a commit that referenced this issue Oct 16, 2019
@chrisklus
Add buckets of dogs, see #2
9907a2b
chrisklus added a commit that referenced this issue Oct 16, 2019
@chrisklus
Adding/removing dogs updates the current number, dogs animate when re…
77697f9 
…turning to bucket, see #2
chrisklus added a commit that referenced this issue Oct 16, 2019
@chrisklus
Changing the current number causes dogs to be added or removed, see #2
beade74
chrisklus added a commit that referenced this issue Oct 16, 2019
@chrisklus
Dogs scale up when in the play area, see #2
694e498
chrisklus added a commit that referenced this issue Oct 16, 2019
@chrisklus
Convert to DragListener, see #2
29f3b28
chrisklus added a commit that referenced this issue Oct 16, 2019
@chrisklus
Fix require statement for DragListener, see #2
79e89be
chrisklus added a commit that referenced this issue Oct 16, 2019
@chrisklus
Fix DragListener option names, see #2
371d3a0
chrisklus added a commit that referenced this issue Oct 16, 2019
@chrisklus
Rename number -> word, see #2
90d829f
chrisklus added a commit that referenced this issue Oct 17, 2019
@chrisklus
Copy files from make-a-ten and modify to start ones accordion box, see …
bae7df6 
…#2
chrisklus added a commit that referenced this issue Oct 17, 2019
@chrisklus
Fix lint errors, see #2
81642c0
chrisklus added a commit that referenced this issue Nov 5, 2019
@chrisklus
Add screen icons, see #2
2bd8842
chrisklus added a commit that referenced this issue Nov 5, 2019
@chrisklus
Add peeled numbers, see #2
b8a2459
chrisklus added a commit that referenced this issue Nov 5, 2019
@chrisklus
Add the grippy lines, see #2
6ca6614
chrisklus added a commit that referenced this issue Nov 5, 2019
@chrisklus
Update image license, see #2
73113ca
chrisklus added a commit that referenced this issue Nov 7, 2019
@chrisklus
Add game screen and update placeholder images, see #2
023657e
chrisklus added a commit that referenced this issue Nov 7, 2019
@chrisklus
Update image license, see #2
c48ffd2
chrisklus added a commit that referenced this issue Nov 11, 2019
@chrisklus
Convert playAreas to not change currentNumber with internal Propertie…
92062cd 
…s, make recreated paper ones not pickable, add guards when setting/reading currentNumberProperty, see #2, #4, #5, #6
chrisklus added a commit that referenced this issue Nov 11, 2019
@chrisklus
Convert organizedObjectPadding to an options pattern, see #2
6b9b11d
chrisklus added a commit that referenced this issue Nov 11, 2019
@chrisklus
Move ones bucket to left corner, see #2
0c5ebdc
chrisklus added a commit that referenced this issue Nov 11, 2019
@chrisklus
Add option to ObjectsPlayArea to provide playObjectTypeProperty, see #2
728a4c7
chrisklus added a commit that referenced this issue Nov 12, 2019
@chrisklus
Fix bug that was causing currentNumberProperty to change when paper o…
f0aedfa 
…nes were combined, see #2
chrisklus added a commit that referenced this issue Nov 12, 2019
@chrisklus
Remove old logging, see #2
ebf7895
chrisklus added a commit that referenced this issue Nov 12, 2019
@chrisklus
Add NumeralAccordionBoxes and CompareAccordionBoxes to the compare sc…
8c07bcd 
…reen, see #2
chrisklus added a commit that referenced this issue Nov 12, 2019
@chrisklus
Update doc, see #2
ec9b477
chrisklus added a commit that referenced this issue Nov 12, 2019
@chrisklus
Add the comparison signs, see #2
dd35e36
chrisklus added a commit that referenced this issue Nov 12, 2019
@chrisklus
Add the block values node, see #2
caec427
chrisklus added a commit that referenced this issue Nov 20, 2019
@chrisklus
Add the number pieces carousel, see #2
fd0289a
chrisklus added a commit that referenced this issue Nov 21, 2019
@chrisklus
Change chip image to ball, see #2
98b90ef
chrisklus added a commit that referenced this issue Dec 2, 2019
@chrisklus
Always animate number pieces, see #2
77650ae
chrisklus added a commit that referenced this issue Dec 2, 2019
@chrisklus
Dogs, balls, and number pieces share same layer, see #2
af8d305
chrisklus added a commit that referenced this issue Dec 2, 2019
@chrisklus
PaperNumberNodes share layer with the rest of the pieces, see #2
5e09b3b
chrisklus added a commit that referenced this issue Dec 3, 2019
@chrisklus
Ten frame nodes can be dragged out of the icon, see #2
2a85a60
chrisklus added a commit that referenced this issue Dec 9, 2019
@chrisklus
Add TODO, see #2
7efc51e
chrisklus added a commit that referenced this issue Dec 19, 2019
@chrisklus
Add language control and speak button to WordAccordionBox, see #2
e651e08
@chrisklus
Copy link
Contributor Author

Sprint was completed December 2019. Closing.

@chrisklus chrisklus mentioned this issue Feb 1, 2021
Closed
15 tasks
chrisklus added a commit to phetsims/counting-common that referenced this issue Jun 4, 2021
@chrisklus
Initialize splitTarget to 0 size, see phetsims/number-play#2
58f89cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisklus chrisklus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisklus