-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise the implementation of model-view transforms. #277
Labels
Comments
This was referenced Jan 12, 2022
The model-view transform was significantly simplified in the above commit. Tested with |
This was referenced Jan 18, 2022
Closed
Reopening. This broken a bunch of things. |
#299 was broken before these changes, as demonstrated in 1.1.0-dev.14. So closing this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This sim has some interesting model-view transform requirements, related to the zoom feature:
*Labels are supposed to translate, but not scale.
The above requirements are implemented via 3 different (but related) transforms, all defined in GOScreenView.js:
modelViewTransform: ModelViewTransform2
zoomTransformProperty: DerivedProperty< ModelViewTransform2 >
zoomScaleProperty: DerivedProperty<number>
Having 3 transforms creates a few problem:
zoomTransformProperty
andzoomScaleProperty
are dynamic (and both derived fromzoomLevelProperty
) is causing ordering dependencies, resulting in problems like (defintely) Incorrect ruler length withshuffleListeners
query parameter #133 and (maybe) Inaccurate rendering withshuffleListeners
query parameter #145.I'm fairly certain that the requirements can be met with a single
Property<ModelViewTransform2>
, and I'll be investigating that.The text was updated successfully, but these errors were encountered: